Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation fixes #3812

Merged
merged 2 commits into from
May 15, 2019
Merged

Conversation

feloy
Copy link
Member

@feloy feloy commented May 14, 2019

Revert some hacks introduced in #3770

  • Revert the usage of hidden hidden element as a workaround for tooltip message logic
  • Add a locale-config parameter to the dashboard binary

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2019
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #3812 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3812      +/-   ##
=========================================
- Coverage   47.14%   47.1%   -0.04%     
=========================================
  Files         171     171              
  Lines        7971    7971              
  Branches       62      62              
=========================================
- Hits         3758    3755       -3     
- Misses       3972    3976       +4     
+ Partials      241     240       -1
Impacted Files Coverage Δ
src/app/backend/handler/localehandler.go 62.71% <0%> (ø) ⬆️
src/app/backend/sync/secret.go 70.29% <0%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0420e4...21d9295. Read the comment docs.

@feloy feloy mentioned this pull request May 14, 2019
@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@maciaszczykm
Copy link
Member

/hold for @floreks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2657e0b into kubernetes:master May 15, 2019
@maciaszczykm
Copy link
Member

Ups, /hold didn't work...

@floreks
Copy link
Member

floreks commented May 15, 2019

It's fine. We did not have support for i18n testing on prod before. LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants