Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Commit

Permalink
Merge pull request #1242 from wongma7/metric-names
Browse files Browse the repository at this point in the history 
Automatic merge from submit-queue.

Update volume operations metric names as implemented

@verult PTAL, thanks! kubernetes/kubernetes#50036 (comment)
  • Loading branch information
@liggitt
Kubernetes Submit Queue authored and liggitt committed Dec 1, 2021
2 parents dbed38c + 84d67dc commit 93f4546
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions storage/volume-metrics.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,27 +50,27 @@ Following is a sample of metrics (not exhaustive) that will be added by this pro
```
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_attach" }
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_detach" }
storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "provision" }
storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "volume_provision" }
storage_operation_duration_seconds { volume_plugin = "gce-pd", operation_name = "volume_delete" }
storage_operation_duration_seconds { volume_plugin = "vsphere", operation_name = "volume_mount" }
storage_operation_duration_seconds { volume_plugin = "iscsi" , operation_name = "volume_unmount" }
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "mount_device" }
storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "unmount_device" }
storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volume" }
storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" }
storage_operation_duration_seconds { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" }
```

Similarly errors will be named:

```
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_attach" }
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_detach" }
storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "provision" }
storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "volume_provision" }
storage_operation_errors_total { volume_plugin = "gce-pd", operation_name = "volume_delete" }
storage_operation_errors_total { volume_plugin = "vsphere", operation_name = "volume_mount" }
storage_operation_errors_total { volume_plugin = "iscsi" , operation_name = "volume_unmount" }
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "mount_device" }
storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "unmount_device" }
storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volume" }
storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" }
storage_operation_errors_total { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" }
```

### Implementation Detail
Expand Down

0 comments on commit 93f4546

Please sign in to comment.