move sidecar to milestone 1.28

keps/sig-node/753-sidecar-containers/README.md

@@ -81,10 +81,10 @@
 
 Items marked with (R) are required *prior to targeting to a milestone / release*.
 
-- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
-- [ ] (R) KEP approvers have approved the KEP status as `implementable`
-- [ ] (R) Design details are appropriately documented
-- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
+- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
+- [X] (R) KEP approvers have approved the KEP status as `implementable`
+- [X] (R) Design details are appropriately documented
+- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
   - [ ] e2e Tests for all Beta API Operations (endpoints)
   - [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md) 
   - [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
@@ -243,9 +243,8 @@ condition is represented with the field `Started` of `ContainerStatus` type. See
 the section ["Pod startup completed condition"](#pod-startup-completed-condition)
 for considerations on picking this signal.
 
-As part of the KEP, init containers and regular containers will be split into
-two different types. The field `restartPolicy` will only be introduced on init
-containers. The only supported value proposed in this KEP is `Always`. No other
+The field `restartPolicy` will only be accepted on init
+containers as part of this KEP. The only supported value proposed in this KEP is `Always`. No other
 values will be defined as part of this KEP. Moreover, the field will be
 nullable so the default value will be "no value". 
 
@@ -274,7 +273,7 @@ containers in the Pod. This intent to solve the issue
 https://github.com/kubernetes/kubernetes/issues/111356 
 
 As part of this KEP we also will be enabling for sidecar containers (those will
-not be enabled for other init containers):
+not be allowed for other init containers):
 - `PostStart` and `PreStop` lifecycle handlers for sidecar containers
 - All probes (startup, readiness, liveness)
 - Readiness probes of sidecars will contribute to determine the whole Pod
@@ -586,7 +585,7 @@ represent the actual resources in use.  The KEP notes that:
 > `Status.ContainerStatuses[i].ResourcesAllocated` when considering available
 > space on a node.
 
-We can introduce `ContainerUse` to represent this value:
+We will introduce `ContainerUse` to represent this value:
 
 ```
 ContainerUse(i) = Max(Spec.Containers[i].Resources, Status.ContainerStatuses[i].ResourcesAllocated)

keps/sig-node/753-sidecar-containers/kep.yaml

@@ -10,7 +10,7 @@ participating-sigs:
   - sig-apps
 status: implementable
 creation-date: 2018-05-14
-last-updated: 2023-02-01
+last-updated: 2023-04-27
 reviewers:
   - "@mrunalp"      # overall
   - "@ffromani"     # resource management
@@ -30,13 +30,13 @@ stage: alpha
 # The most recent milestone for which work toward delivery of this KEP has been
 # done. This can be the current (upcoming) milestone, if it is being actively
 # worked on.
-latest-milestone: "v1.27"
+latest-milestone: "v1.28"
 
 # The milestone at which this feature was, or is targeted to be, at each stage.
 milestone:
-  alpha: "v1.27"
-  beta: "v1.28"
-  stable: "v1.30"
+  alpha: "v1.28"
+  beta: "v1.29"
+  stable: "v1.32"
 
 # The following PRR answers are required at alpha release
 # List the feature gate name and the components for which it must be enabled