Skip to content

Commit

Permalink
Merge pull request #3825 from andrewsykim/kep-1669
Browse files Browse the repository at this point in the history
kep-1669: add GA graduation criterias for v1.27
  • Loading branch information
k8s-ci-robot authored Feb 6, 2023
2 parents 02d4df4 + 1b5e22e commit 790dafa
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-network/1669.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"
7 changes: 7 additions & 0 deletions keps/sig-network/1669-proxy-terminating-endpoints/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
- [Graduation Criteria](#graduation-criteria)
- [Alpha](#alpha)
- [Beta](#beta)
- [GA](#ga)
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
- [Version Skew Strategy](#version-skew-strategy)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
Expand Down Expand Up @@ -190,6 +191,7 @@ and internalTrafficPolicy.
- E2E test validating fallback behavior for terminating endpoints when `externalTrafficPolicy: Local`: https://github.com/kubernetes/kubernetes/blob/4bc1398c0834a63370952702eef24d5e74c736f6/test/e2e/network/service.go#L3145
- E2E test validating fallback behaviro for terminating endpoints when `internalTrafficPolicy: Cluster`: https://github.com/kubernetes/kubernetes/blob/4bc1398c0834a63370952702eef24d5e74c736f6/test/e2e/network/service.go#L2889
- E2E test validating fallback behaviro for terminating endpoints when `internalTrafficPolicy: Local`: https://github.com/kubernetes/kubernetes/blob/4bc1398c0834a63370952702eef24d5e74c736f6/test/e2e/network/service.go#L2972
- E2E test performing rolling update with an LB using `externalTrafficiPolicy: Local`: https://github.com/kubernetes/kubernetes/blob/f333e5b4c5a174c63ac8e71f2c187f434ce56b1b/test/e2e/network/loadbalancer.go#L1283-L1299

### Graduation Criteria

Expand All @@ -206,6 +208,11 @@ and internalTrafficPolicy.
* Metrics to publish how many Services/Endpoints are routing traffic to terminating endpoints.
* Manual or automated rollback testing (see [Test Plan](#test-plan) section)

#### GA

* Feedback from users in issue [85643](https://github.com/kubernetes/kubernetes/issues/85643) that enabling ProxyTerminatingEndpoints can achieve zero downtime rolling updates when using `externalTrafficPolicy: Local`
* E2E tests demonstrating that rolling updates can be performed with negligible downtime (ideally 100%, but may not feasible without flakiness) with a Service LoadBalancer when using externalTrafficPolicy: Local

### Upgrade / Downgrade Strategy

Behavioral changes to terminating endpoints will apply when the feature gate is enabled. It is required that the cluster has the EndpointSlice API enabled and
Expand Down
7 changes: 4 additions & 3 deletions keps/sig-network/1669-proxy-terminating-endpoints/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,24 +12,25 @@ reviewers:
approvers:
- "@thockin"
creation-date: 2020-04-07
last-updated: 2022-01-21
last-updated: 2023-02-02
status: implementable
see-also:
- "/keps/sig-network/1672-tracking-terminating-endpoints/README.md"
- https://github.com/kubernetes/kubernetes/issues/85643

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.26"
latest-milestone: "v1.27"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.22"
beta: "v1.26"
stable: "v1.27"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand Down

0 comments on commit 790dafa

Please sign in to comment.