Skip to content

Commit

Permalink
applied the feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@SergeyKanzhelev
SergeyKanzhelev committed Feb 9, 2023
1 parent 9494d2c commit ace2cc6
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions keps/sig-node/753-sidecar-containers/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1074,8 +1074,11 @@ No.
Yes. Pods that had sidecars will need to be deleted and recreated without them.

The feature gate disablement will require the kubelet restart. When kubelet will
start, it will fail to reconcile the Pod with new fields and will clean up all
running containers.
start, it will fail to reconcile the Pod with the new fields and will clean up
all running containers.

If version downgrade is involved, the node must be drained. All Pods with the
new field will not be accepted by kubelet once feature was disabled.

###### What happens if we reenable the feature if it was previously rolled back?

Expand Down

0 comments on commit ace2cc6

Please sign in to comment.