Azure disk in-tree to CSI driver migration

[davidz627]

Enhancement Description

• One-line enhancement description (can be used as a release note): Migrate the internals of in-tree Azure Disk Plugin to call out to the Azure Disk CSI Driver respectively while maintaining the original API
• Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md
• Primary contact (assignee): @andyzhangx
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release: 1.15
  • Beta release: 1.19
  • Stable release target (x.y): v1.24

Parent enhancement: #625
Public Migration testing CI: LINK

TODO

• Replace design/KEP with specific one if needed
• Link public migration testing CI

[davidz627]

/sig storage

[andyzhangx]

azure disk & file won't go BETA on 1.18 since there is dependency on csi windows, if we go beta, that means all requests for built-in driver would be redirected to csi driver, while csi driver does not work on Windows, that will break azure disk & file driver on Windows

[andyzhangx]

/sig cloud-provider
/area provider/azure

[andyzhangx]

@davidz627 thanks for driving this

[feiskyer]

/assign @andyzhangx

[davidz627]

@andyzhangx feel free to edit description, you are the owner of this issue now :)

[jeremyrickard]

@feiskyer @andyzhangx should we track this for 1.18? It looks like your description indicates you plan to go beta on this, but the linked issue indicates you're blocked by some windows things?

[feiskyer]

/milestone v1.19

[jeremyrickard]

Thanks @feiskyer!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[palnabarun]

/remove-lifecycle stale

[palnabarun]

Hi @feiskyer -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate to Beta in 1.19?

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[andyzhangx]

Azure disk & azure file migration would go beta in 1.19, here is the PR: kubernetes/kubernetes#90896

[palnabarun]

Hi @andyzhangx 👋 , thank you for the update. I've updated the tracking sheet accordingly.

Let us know if there are any other PR's that you would want to track for this release.

[rhockenbury]

/stage stable
/tracked yes

[rhockenbury]

Hi @andyzhangx! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting stable for 1.24.

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo. - PENDING KEP-1490: Add csi migration kep for Azuredisk #3109
• KEP status is marked as implementable for latest-milestone: 1.24 - PENDING KEP-1490: Add csi migration kep for Azuredisk #3109
• KEP has a test plan section filled out. - COMPLETE IN PARENT KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration
• KEP has up to date graduation criteria. - COMPLETE IN PARENT KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration
• KEP has a production readiness review that has been completed and merged into k/enhancements. - PENDING KEP-1490: Add csi migration kep for Azuredisk #3109

The status of this enhancement is at risk. Thanks!

[andyzhangx]

@davidz627 could you mark the target as 1.25 as GA in this issue? Thanks.

[andyzhangx]

@davidz627 BTW, you will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

[msau42]

@andyzhangx can you confirm if you want to target GA in 1.24 or 1.25?

[andyzhangx]

@msau42 Azure disk target GA in 1.24

[msau42]

You will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@andyzhangx I think it's better if you submit the PR after you have finished all the necessary testing and other GA requirements.

[andyzhangx]

You will submit a PR to mark the GA status for all cloud provider drivers in k/k, right?

@andyzhangx I think it's better if you submit the PR after you have finished all the necessary testing and other GA requirements.

@msau42 here is the PR: kubernetes/kubernetes#107681

[rhockenbury]

I see that #3109 has been merged. I have updated the status to tracked for enhancement freeze.

[didicodes]

Hi @andyzhangx, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

[rhockenbury]

Hi @andyzhangx

I'm checking in as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this KEP, it looks like just k/k#107681 needs to be merged. Let me know if there are any other PRs that we should be tracking for 1.24 code freeze.

Let me know if you have any questions.

[rhockenbury]

Friendly reminder to try to merge k/k#107681 before code freeze at 01:00 UTC Wednesday 30th March 2022.

[andyzhangx]

kubernetes/kubernetes#107681 is already merged, so we could close this issue now? @msau42

[Priyankasaggu11929]

Hello @andyzhangx @davidz627 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

[andyzhangx]

thanks, I have worked out a PR: #3300

[andyzhangx]

/close

[k8s-ci-robot]

@andyzhangx: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.