release issue for feature CSIServiceAccountToken

[zshihang]

Enhancement Description

• One-line enhancement description (can be used as a release note): feature CSIServiceAccountToken plumbs down pod's service account token to CSI driver
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/1855-csi-driver-service-account-token/README.md
• Discussion Link: None.
• Primary contact (assignee): @zshihang
• Responsible SIGs: sig-storage, sig-auth
• Enhancement target (which target equals to which milestone):
  • Alpha release target (1.20)
  • Beta release target (1.21)
  • Stable release target (1.22)
• 1.20
  • KEP (k/enhancements) update PR(s):
    • propose a way to get service account token for csi driver #1855
    • update kep to be eiligible for 1.20 #2061
  • Code (k/k) update PR(s):
    • plumb service account token down to csi driver kubernetes#93130
  • Docs (k/website) update PR(s):
    • add doc for TokenRequests and RequiresRepublish fields kubernetes-csi/docs#383
    • add doc for CSIServiceAccountToken website#24754
    • add description for CSIServiceAccountToken website#25028
• 1.21
  • KEP (k/enhancements) update PR(s):
    • prepare CSIServiceAccountToken for beta #2260
  • Code (k/k) update PR(s):
    • graduate CSIServiceAccountToken to beta kubernetes#99298
• 1.22
  • KEP (k/enhancements) update PR(s):
    • CSIServiceAccountToken going GA #2664
  • Code (k/k) update PR(s):
    • CSIServiceAccountToken ga kubernetes#103001

[zshihang]

/sig storage
/sig auth

[msau42]

Hi @kubernetes/release-team, we would like to track this alpha feature for 1.20

[kikisdeliveryservice]

@zshihang @msau42

Enhancements Lead here 👋

The graduation criteria on this are confusing bc the alpha->beta seems to be what I would expect for alpha? Can you clarify between what's getting delivered in alpha vs in beta?

[zshihang]

yea, that's for alpha.

[kikisdeliveryservice]

@zshihang please update to make it clear?

[kikisdeliveryservice]

@zshihang

As an FYI Enhancements Freeze is October 6th. To be included in the milestone:
The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria (missing alpha/needs to be clarified)

Also if you could update your kep.yaml to include milestones that would be great. See the template for details:

enhancements/keps/NNNN-kep-template/kep.yaml

Line 26 in e97a687

# The target maturity stage in the current dev cycle for this KEP.

[zshihang]

@kikisdeliveryservice updated the KEP in #2061.

[kikisdeliveryservice]

@kikisdeliveryservice updated the KEP in #2061.

KEP LGTM! Just needs to merge 😄

Update: it merged!!

[kendallroden]

Hey @zshihang!

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

[eagleusb]

Hello @zshihang 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[zshihang]

does the documentation for csi follow the same process? @msau42

looks like csi has its own documentation at https://kubernetes-csi.github.io/docs

[msau42]

Since this feature is targeted towards csi driver authors and not k8s end users, https://kubernetes-csi.github.io/docs is the right place to document this feature.

Although since this feature does require a kubernetes feature gate, we should at least document the feature gate in the kubernetes docs.

[annajung]

Hi @zshihang

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline DONE!
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[kendallroden]

Hi @zshihang! Just a quick reminder that tonight is code freeze for 1.20! It looks like there are still reviews outstanding on your implementation PR. Please feel free to reach out or ping me on slack should your intent be to push to 1.21. Otherwise, if the PR doesn't merge by the deadline, you will need to file an exception to be included in the milestone. Thanks so much!!

[kikisdeliveryservice]

kubernetes/kubernetes#93130 is now fully approved and just waiting to merge!

[zshihang]

merged now

[annajung]

With kubernetes/kubernetes#99298 merged, we will mark this as code complete for the 1.21 release. Thanks!

[JamesLaverack]

Hey @zshihang, v1.22 Enhancements Lead here.

I see you've got a PR open for your KEP, which looks in a good state. The only thing I need to mention is that that needs to merge before enhancements freeze.

Let me know if you have any questions.

[JamesLaverack]

Oh one other thing @zshihang, I see that SIG Auth are listed as a participating SIG in your KEP. Will they have to do any work on this in 1.22, and if so are they happy to do that?

[zshihang]

yea, i am working it.

[JamesLaverack]

@zshihang With #2664 merged I think this is all good for enhancements freeze in terms of your KEP. :)

Can you confirm about SIG Auth's participation? Do they need to do anything and if so are they happy with that in 1.22?

[PI-Victor]

Hello @zshihang 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

p.s.: please don't forget to update CSIServiceAccountToken in the feature gates table to reflect this change.

[salaxander]

Hi @zshihang - Can you open a PR on the KEP and change the state to implemented? At that point we can close the issue out. :)

Thanks!

[zshihang]

/close

[k8s-ci-robot]

@zshihang: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.