Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipBlock for Network Policies #367

Closed
cmluciano opened this issue Jul 28, 2017 · 26 comments
Closed

ipBlock for Network Policies #367

cmluciano opened this issue Jul 28, 2017 · 26 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@cmluciano
Copy link

cmluciano commented Jul 28, 2017

Feature Description

  • One-line feature description (can be used as a release note):
    • CIDR selector support for egress/ingress network policies
  • Primary contact (assignee): @cmluciano
  • Responsible SIGs: SIG-Network
  • Design proposal link (community repo): Support CIDR on ingress network-policy kubernetes#49978
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @caseydavenport @danwinship
  • Approver (likely from SIG/area to which feature belongs): @thockin
  • Feature target (which target equals to which milestone):
    • Beta release target (1.8)
    • Stable release target (1.11)
@cmluciano cmluciano added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jul 28, 2017
@cmluciano cmluciano added this to the 1.8 milestone Jul 28, 2017
@cmluciano cmluciano self-assigned this Jul 28, 2017
@cmluciano cmluciano added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jul 28, 2017
@cmluciano
Copy link
Author

code complete in kubernetes/kubernetes#50033.

TODO:

  • More e2es
  • Docs

@jdumars
Copy link
Member

jdumars commented Sep 15, 2017

@cmluciano any update on missing docs? The PR is due today.

@jdumars
Copy link
Member

jdumars commented Sep 18, 2017

@caseydavenport @cmluciano mentioned you as the contact for docs. We need them ASAP in order to make the 1.8 release docs.

@caseydavenport
Copy link
Member

caseydavenport commented Sep 19, 2017

Docs PR is here: kubernetes/website#5529

@cmluciano cmluciano changed the title [Beta] CIDR Selectors for Network Policies [Beta] ipBlock for Network Policies Sep 25, 2017
@cmluciano
Copy link
Author

cmluciano commented Sep 25, 2017

Docs fixed in kubernetes/website#5473

@cmluciano
Copy link
Author

this was merged for 1.8

@cmluciano cmluciano modified the milestones: 1.8, next-milestone Oct 23, 2017
@cmluciano cmluciano added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 23, 2017
@cmluciano
Copy link
Author

reopening for tracking stable

@cmluciano cmluciano reopened this Oct 23, 2017
@cmluciano cmluciano changed the title [Beta] ipBlock for Network Policies [GA] ipBlock for Network Policies Oct 23, 2017
@idvoretskyi
Copy link
Member

@cmluciano @kubernetes/sig-network-feature-requests still on track for 1.10?

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2018
@cmluciano
Copy link
Author

This is still under discussion in the mailing list.

@idvoretskyi
Copy link
Member

@cmluciano any progress?

@cmluciano
Copy link
Author

Yes, from our mailing list conversations this feature with not GA in 1.10. We will continue discussing potential for future releases on the sig-network mailing list.

@idvoretskyi
Copy link
Member

@cmluciano got it, will mark with 1.10 milestone and keep beta for now.

PS. The same is for #366 (comment)

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.10 Jan 22, 2018
@idvoretskyi idvoretskyi removed the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Jan 22, 2018
@idvoretskyi
Copy link
Member

@cmluciano also updated the description to plan GA for 1.11 (for both features). Correct me if I wrong.

@idvoretskyi idvoretskyi changed the title [GA] ipBlock for Network Policies ipBlock for Network Policies Jan 22, 2018
@cmluciano
Copy link
Author

There is ongoing discussion on NetworkPolicy as a whole. Can we hold off on marking a stable milestone until these conversations conclude?

@idvoretskyi
Copy link
Member

@cmluciano please, do.

@idvoretskyi idvoretskyi modified the milestones: v1.10, next-milestone Jan 29, 2018
@justaugustus
Copy link
Member

@cmluciano
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@justaugustus justaugustus removed this from the next-milestone milestone Jul 2, 2018
@justaugustus
Copy link
Member

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus justaugustus added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 4, 2018
@danwinship
Copy link
Contributor

doh, we did all of the discussion for this feature on the egress PR (#366) and forgot to update this PR as well.

Let's see if this still works:

/milestone v1.12
/remove-stage beta
/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Aug 31, 2018
@danwinship
Copy link
Contributor

@justaugustus, @kacole2, @robertsandoval, @rajendar38 This was supposed to have been tracked for 1.12 but we basically forgot that we had two separate feature PRs. All of the work is done, including tests and docs.

@danwinship
Copy link
Contributor

(ping @cmluciano)

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
@kacole2
Copy link

kacole2 commented Sep 7, 2018

@danwinship I've got ahead and added this to the tracking sheet after seeing @tpepper +1 on the exception filed.

@danwinship
Copy link
Contributor

@kacole2 Thanks! It probably should have milestone v1.12 too?

@kacole2
Copy link

kacole2 commented Sep 7, 2018

@danwinship it should but I don't have those powers yet.
@justaugustus can you add the correct labels?

@justaugustus
Copy link
Member

Fixed!
/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 7, 2018
@justaugustus justaugustus added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 7, 2018
@kacole2
Copy link

kacole2 commented Sep 28, 2018

/close

@k8s-ci-robot
Copy link
Contributor

@kacole2: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kacole2 kacole2 removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

8 participants