PodDisruptionBudget and /eviction subresource

[davidopp]

Enhancement Description

• One-line enhancement description (can be used as a release note): PodDisruptionBudget is an API object that specifies the minimum number or percentage of replicas of a collection that must be up at a time, and/or the maximum eviction rate across the collection. Components that wish to eviction a pod subject to disruption budget use the /eviction subresource on pod; unlike a regular pod deletion, this operation may be rejected by the API server if the eviction would cause a disruption budget to be violated.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/85-Graduate-PDB-to-Stable
• Primary contact (assignee): @mortent
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.4
  • Beta release target (x.y): 1.5
  • Stable release target (x.y): 1.21 (PDB), 1.22 (Eviction)
• Alpha
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):
• Beta
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update(s):
• Stable
  • KEP (k/enhancements) update PR(s): Update PDB KEP with latest status #2591
  • Code (k/k) update PR(s): Promote PodDisruptionBudget to policy/v1 kubernetes#99290
  • Docs (k/website) update(s): Promote Pod Disruption Budgets to GA website#27053, Update eviction example to use policy/v1 website#27810

[davidopp]

cc/ @mml

[jaredbhatti]

@davidopp Are docs required for this feature?

[davidopp]

Yes, @mml is starting to work on it.

[jaredbhatti]

@mml Another ping on docs. Any PRs you can point me to?

[davidopp]

Planning to move this to Beta in 1.5, see kubernetes/kubernetes#25321

[erictune]

Please consider kubernetes/kubernetes#34776 before beta, as addressing it might be a breaking API change (makes a required field optional).

[davidopp]

Is it really not allowed to add a mutually exclusive field once something is already in Beta? I don't understand why that would be the case (I may be missing something though). I thought the "backward compatibility" requirement for Beta just meant that an object from the old API version has to be usable in the new binary version. It seems that would be the case, since the new binary version understands both fields.

[idvoretskyi]

@davidopp can you confirm that this item targets beta in 1.6?

[davidopp]

It was beta in 1.5. beta-in-1.5 label looks correct.

We don't have any short-term plan for additional work on this, so I'll close.

[mikedanese]

@davidopp when is this going to GA? should we keep this open until then?

cc @maisem

[davidopp]

Yeah, let's reopen until it goes to GA. Not sure when that's happening, so I've removed the milestone. The sig-apps folks have had various ideas for changes we should make before GA but we haven't had bandwidth to discuss it. I assume the discussion will happen on kubernetes/kubernetes#25321

[liggitt]

1.22 work is complete:

• KEP: Update PDB KEP with latest status #2591
• PR: Add policy/v1 Eviction support kubernetes#100724
• Docs: Update eviction example to use policy/v1 website#27810

[JamesLaverack]

Hey @liggitt, 1.22 enhancements lead here 👋

This is broadly good, but I have a couple of questions:

• Can you set the latest-milestone key in your kep.yaml to be "v1.22"?
• After the changes to your KEP do any of the PRR questions need to be revisited?

[liggitt]

Can you set the latest-milestone key in your kep.yaml to be "v1.22"?

Done in #2683

After the changes to your KEP do any of the PRR questions need to be revisited?

No, the 1.22 completions don't modify any PRR responses.

[JamesLaverack]

Great. With that merged you're all set for 1.22 enhancements freeze. 🎉

[JamesLaverack]

I'd normally ask if your participating SIG (SIG Scheduling) needed to do anything — but if you've already completed your k/k PR I'm going to assume you're all set. 😄

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[liggitt]

this was completed in 1.22

/close

[k8s-ci-robot]

@liggitt: Closing this issue.

In response to this:

this was completed in 1.22

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.