Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex volume API and Improved lifecycle (flexvolume) #93

Closed
23 tasks
chakri-nelluri opened this issue Sep 13, 2016 · 18 comments
Closed
23 tasks

Flex volume API and Improved lifecycle (flexvolume) #93

chakri-nelluri opened this issue Sep 13, 2016 · 18 comments
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@chakri-nelluri
Copy link

chakri-nelluri commented Sep 13, 2016

Description

Existing flex volume plugin enables administrators/vendors to create out-of-tree volume plugins, i.e., plugins which do not reside in Kubernetes project. But, it has the following gaps.

It lacks support for the latest enhancements to in-tree plugins like dynamic provisioning and centralized attach-detach controller
It does not define a stable driver api for administrators/vendors to work.
The current flex volume plugin deployment model is not suitable for environments like GCE & CoreOS, where access to the root file system is restricted. And in other environments the overall user experience is poor, as it requires manual installation of the plugin on every node and restart of kubelets & controller manager.

Progress Tracker

  • Before Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
      • Design Proposal. This goes under docs/proposals. Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation. Paste link to merged design proposal here: PROPOSAL-NUMBER
      • Decide which repo this feature's code will be checked into. Not everything needs to land in the core kubernetes repo. REPO-NAME
      • Initial API review (if API). Maybe same PR as design doc. PR-NUMBER
        • Any code that changes an API (/pkg/apis/...)
        • cc @kubernetes/api
      • Identify shepherd (your SIG lead and/or [email protected] will be able to help you). My Shepherd is: [email protected] (and/or GH Handle)
        • A shepherd is an individual who will help acquaint you with the process of getting your feature into the repo, identify reviewers and provide feedback on the feature. They are not (necessarily) the code reviewer of the feature, or tech lead for the area.
        • The shepherd is not responsible for showing up to Kubernetes-PM meetings and/or communicating if the feature is on-track to make the release goals. That is still your responsibility.
      • Identify secondary/backup contact point. My Secondary Contact Point is: [email protected] (and/or GH Handle)
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs
        • cc @kubernetes/docs on docs PR
        • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
        • New apis: Glossary Section Item in the docs repo: kubernetes/kubernetes.github.io
      • Update release notes
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
      • cc @kubernetes/docs on docs PR
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Thorough API review
      • cc @kubernetes/api
  • Before Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off
    • Soak, load testing
    • detailed user docs and examples
      • cc @kubernetes/docs
      • cc @kubernetes/feature-reviewers on this issue to get approval before checking this off

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@chakri-nelluri chakri-nelluri changed the title Flex volume API proposal Flex volume API and Improved lifecycle Sep 13, 2016
@chakri-nelluri
Copy link
Author

@gr4701 @thockin @philips Create new Feature request for Flex volume proposals:
kubernetes/kubernetes#32543
kubernetes/kubernetes#32550

@philips philips changed the title Flex volume API and Improved lifecycle Flex volume API and Improved lifecycle (flexvolume) Oct 18, 2016
@idvoretskyi idvoretskyi added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 3, 2016
@idvoretskyi
Copy link
Member

@chakri-nelluri can you provide the actual status of the feature? Which SIG is responsible for it?

@saad-ali
Copy link
Member

@kubernetes/sig-storage is responsible for this feature.

It is not part of 1.5

@idvoretskyi idvoretskyi added this to the next-milestone milestone Nov 10, 2016
@idvoretskyi idvoretskyi added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 10, 2016
@idvoretskyi
Copy link
Member

@saad-ali thank you!

@childsb childsb modified the milestones: v1.6, next-milestone Dec 8, 2016
@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.6 Jan 12, 2017
@idvoretskyi
Copy link
Member

@saad-ali which release does this feature target and which stage (alpha/beta/stable)?

@mdelio mdelio modified the milestones: v1.6, next-milestone Jan 23, 2017
@mdelio
Copy link

mdelio commented Jan 23, 2017

@idvoretskyi alpha in 1.6

@calebamiles calebamiles added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2017
@idvoretskyi
Copy link
Member

@chakri-nelluri @mdelio please, provide us with the release notes and documentation PR (or links) at https://docs.google.com/spreadsheets/d/1nspIeRVNjAQHRslHQD1-6gPv99OcYZLMezrBe3Pfhhg/edit#gid=0

@jaredbhatti
Copy link

Pingity ping. Is there a Docs PR for this? Is one needed?

@childsb
Copy link
Contributor

childsb commented Mar 17, 2017

@jaredbhatti is this enough for docs: kubernetes/kubernetes#43326 or do we need a PR against kubernetes/kubernetes.github.io also?

@jaredbhatti
Copy link

jaredbhatti commented Mar 17, 2017 via email

@chakri-nelluri
Copy link
Author

chakri-nelluri commented Mar 20, 2017 via email

@calebamiles
Copy link
Contributor

@chakri-nelluri, please confirm with @saad-ali and @devin-donnelly that no updates are needed to the user facing documentation at k8s.io.

cc: @ethernetdan, @kubernetes/release-team

@chakri-nelluri
Copy link
Author

/close

@luxas
Copy link
Member

luxas commented Aug 23, 2017

@chakri-nelluri Where is this feature or its successor now tracked?

@zhangxiaoyu-zidif
Copy link

zhangxiaoyu-zidif commented Aug 29, 2017

@luxas
After I check these features. It seems that these two features are both abandoned.
Sad :(

@chakri-nelluri
Copy link
Author

Hi @luxas this will be superseded by CSI. https://github.com/container-storage-interface/spec

@luxas
Copy link
Member

luxas commented Sep 1, 2017

@chakri-nelluri So #178 is the successor, right?

@chakri-nelluri
Copy link
Author

@luxas. Yes #178 is the successor. Thanks

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
howardjohn pushed a commit to howardjohn/enhancements that referenced this issue Oct 21, 2022
* Update external istiod feature

* beta

* update checkboxes

* add comment

* spelling

* check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests

10 participants