Add test plan from design doc to KEP for CSI storage migration #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
sig/storage
k8s-ci-robot
requested review from
andyzhangx,
ddebroy,
leakingtapan and
xing-yang
k8s-ci-robot
added
cncf-cla: yes
2 tasks
davidz627
force-pushed
the
migrationTestPlan
branch
from
27f309c
to
01a3be2
Compare
|
Thank you for the quick response @davidz627 /lgtm |
k8s-ci-robot
added
the
lgtm
saad-ali
approved these changes
Jan 23, 2020
davidz627
force-pushed
the
migrationTestPlan
branch
from
01a3be2
to
996bee8
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
lgtm
|
Hey @davidz627, there is a small spelling error in the KEP that needs to get fixed to pass the
|
davidz627
force-pushed
the
migrationTestPlan
branch
from
996bee8
to
cdf166e
Compare
k8s-ci-robot
removed
the
lgtm
misterikkit
suggested changes
Jan 24, 2020
| |-------------------|----------------------------------------------------|--------------------------------------------------------------------------| | ||
| | ADC Migration On | Kubelet Migration On | Fully migrated - result should be same as “Migration Shim Testing” above | | ||
| | ADC Migration On | Kubelet Migration Off (or Kubelet version too low) | No calls made to driver. All operations serviced by in-tree plugin | | ||
| | ADC Migration Off | Kubelet Migration On | Not supported config - Undefined behavior | |
There was a problem hiding this comment.
is this possible in a downgrade scenario? or do nodes downgrade before control plane?
There was a problem hiding this comment.
nodes must be downgraded before the controller
davidz627
force-pushed
the
migrationTestPlan
branch
from
cdf166e
to
1dbdedd
Compare
davidz627
force-pushed
the
migrationTestPlan
branch
from
1dbdedd
to
272972d
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, jeremyrickard, misterikkit, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @jeremyrickard
/assign @saad-ali @jsafrane @msau42 @misterikkit
/cc @ddebroy @leakingtapan @andyzhangx @xing-yang
Copying over test plan from design doc and clarifying some specific points.
/sig storage