Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KEP 2464: Kubetest2 CI migration #2465

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Conversation

amwat
Copy link
Contributor

@amwat amwat commented Feb 8, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 8, 2021
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to see, thank you @amwat! 🙏

keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
Consider including folks who also work outside the SIG or subproject.
-->

- Stage 1 of shipping the kubetest2 binary involves keeping HEAD at kubetest2 unbroken (same as kubetest currently).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan we probably should target a v1.0.0/v1 release of k/release to freeze our API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert would that be required as part of this KEP?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep this a separate topic in k/release, WDYT?

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
As SIG Testing approver.

/hold
But I have some suggested changes I'd like to see before /lgtm

keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/README.md Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/kep.yaml Outdated Show resolved Hide resolved
keps/sig-testing/2464-kubetest2-ci-migration/kep.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
.gitignore Outdated
@@ -24,3 +24,4 @@ Session.vim

# Files generated by JetBrains IDEs, e.g. IntelliJ IDEA
.idea/
*.iml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you drop this change? This is requiring root approval

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Feb 9, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 82fa8bb into kubernetes:master Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 9, 2021
@amwat amwat deleted the kubetest2 branch February 9, 2021 22:51
@amwat amwat mentioned this pull request Feb 9, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants