Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keps/sig-testing: refresh KEP status #2867

Merged
merged 6 commits into from
Aug 17, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 16, 2021

If folks would prefer I break this up into a PR-per-KEP I can do that
too...

I wanted to make sure the output of kepctl query --sig testing
reflected reality. A number of fields were missing or stale, so I
reconciled:

  • if we're aiming for graduation this cycle,the KEP is status: implementable
    and stage: the-target-stage-for-this-release
  • if this is a retroactive change, the KEP is status: implemented and
    stage: whatever-stage-was-reached
  • KEPs done before we had formal graduation criteria or implementation
    history had best guesses added
  • a scope: out-of-tree field was added to KEPs primarily covering code
    not in kubernetes/kubernetes
  • a scope: in-tree field was added to KEPs primarily covering code in
    kubernetes/kubernetes, even if it wasn't compiled into a release
    binary used to run a kubernetes cluster
  • avoid @foo in kep.yaml in favor of foo and generally reduce the "amount"
    "of" "things" "wrapped" "in" "quotes"

Broke out proposed v1.23 KEP graduations to #2871

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Aug 16, 2021
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 16, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 16, 2021

/cc @BenTheElder
for #2420 changes
/cc @amwat
for #2464 changes
/cc @chaodaiG
for #2539 changes

Copy link
Contributor

@chaodaiG chaodaiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from my side

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Aug 16, 2021

/cc

Thanks for this @spiffxp, I’ll review later this evening when I get back from school pickup and kid stuff (if you need another review)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Aug 16, 2021

We don't officially have a scope field so I'd prefer to not add them unilaterally to KEPs until there is a clear policy and the template is officially updated.

In the meantime, you can make sure that the open issues have label: out-of-tree

@kikisdeliveryservice kikisdeliveryservice added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2021
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@kikisdeliveryservice
Copy link
Member

Thanks for updating the keps!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

We don't officially have a scope field so I'd prefer to not add them unilaterally to KEPs until there is a clear policy and the template is officially updated.

Opened #2870 so tests can enforce "KEP-related YAML should only contain well-known fields"

@spiffxp spiffxp force-pushed the update-sig-testing-keps branch 2 times, most recently from 8586350 to 5e93d3f Compare August 17, 2021 17:26
specifically

- retroactively refresh; this KEP was completed well before we migrated
  over to the new format, so it's best guess only for things I filled in
- drop the `@` from users so things don't need to be quote-wrapped
specifically

- retroactively refresh; this KEP was completed well before we migrated
  over to the new format, so it's best guess only for things I filled in
- drop the `@` from users so things don't need to be quote-wrapped
specifically:

- drop quote-wrapping
specifically:

- drop quote-wrapping
- best guesses at steps taken to get to stable
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
- "@BenTheElder"
- "@cblecker"
- "@stevekuznetsov"
- fejta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can automate normalizing this (parse and spit back out?) and stick it in a linter /shrug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kepctl could totally do this, I just didn't want to change the world while there are ~100 PR's outstanding

@@ -556,6 +556,7 @@ Major milestones might include:
- 2020-02-08 - KEP Implementable [#2469](https://github.com/kubernetes/enhancements/pull/2469)
- 2020-04-01 - KEP Alpha, Beta in Kubernetes 1.21
- There is no distinct alpha/beta for this KEP, only alpha/beta (implemented at HEAD) vs stable (all supported branches)
- 2020-08-16 - Retroactive implemented declaration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't all implemented declarations retroactive? /shrug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider it retroactive since we didn't make the declaration during the release cycle, but two cycles (ish, I guess 1.23 hasn't started) after it was done

@BenTheElder
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

/hold cancel
Thanks for the reviews all!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4e068bd into kubernetes:master Aug 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 17, 2021
@kikisdeliveryservice
Copy link
Member

We don't officially have a scope field so I'd prefer to not add them unilaterally to KEPs until there is a clear policy and the template is officially updated.

Opened #2870 so tests can enforce "KEP-related YAML should only contain well-known fields"

Thank you!!!!

@spiffxp spiffxp deleted the update-sig-testing-keps branch August 27, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants