-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keps/sig-testing: refresh KEP status #2867
keps/sig-testing: refresh KEP status #2867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve from my side
/cc Thanks for this @spiffxp, I’ll review later this evening when I get back from school pickup and kid stuff (if you need another review) |
770482f
to
6e1af59
Compare
We don't officially have a scope field so I'd prefer to not add them unilaterally to KEPs until there is a clear policy and the template is officially updated. In the meantime, you can make sure that the open issues have label: out-of-tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6e1af59
to
65cfec9
Compare
keps/sig-testing/2291-presubmit-config-inside-the-tested-repo/README.md
Outdated
Show resolved
Hide resolved
Thanks for updating the keps! /hold cancel |
Opened #2870 so tests can enforce "KEP-related YAML should only contain well-known fields" |
8586350
to
5e93d3f
Compare
specifically - retroactively refresh; this KEP was completed well before we migrated over to the new format, so it's best guess only for things I filled in - drop the `@` from users so things don't need to be quote-wrapped
specifically - retroactively refresh; this KEP was completed well before we migrated over to the new format, so it's best guess only for things I filled in - drop the `@` from users so things don't need to be quote-wrapped
specifically: - drop quote-wrapping
specifically: - drop quote-wrapping - best guesses at steps taken to get to stable
5e93d3f
to
8d8e3f0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- "@BenTheElder" | ||
- "@cblecker" | ||
- "@stevekuznetsov" | ||
- fejta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can automate normalizing this (parse and spit back out?) and stick it in a linter /shrug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kepctl
could totally do this, I just didn't want to change the world while there are ~100 PR's outstanding
@@ -556,6 +556,7 @@ Major milestones might include: | |||
- 2020-02-08 - KEP Implementable [#2469](https://github.com/kubernetes/enhancements/pull/2469) | |||
- 2020-04-01 - KEP Alpha, Beta in Kubernetes 1.21 | |||
- There is no distinct alpha/beta for this KEP, only alpha/beta (implemented at HEAD) vs stable (all supported branches) | |||
- 2020-08-16 - Retroactive implemented declaration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't all implemented declarations retroactive? /shrug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consider it retroactive since we didn't make the declaration during the release cycle, but two cycles (ish, I guess 1.23 hasn't started) after it was done
/lgtm |
/hold cancel |
Thank you!!!! |
If folks would prefer I break this up into a PR-per-KEP I can do that
too...
I wanted to make sure the output of
kepctl query --sig testing
reflected reality. A number of fields were missing or stale, so I
reconciled:
status: implementable
and
stage: the-target-stage-for-this-release
status: implemented
andstage: whatever-stage-was-reached
history had best guesses added
scope: out-of-tree
field was added to KEPs primarily covering codenot in kubernetes/kubernetes
scope: in-tree
field was added to KEPs primarily covering code inkubernetes/kubernetes, even if it wasn't compiled into a release
binary used to run a kubernetes cluster
@foo
in kep.yaml in favor offoo
and generally reduce the "amount""of" "things" "wrapped" "in" "quotes"
Broke out proposed v1.23 KEP graduations to #2871