Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2907: secrets store csi driver #2939

Merged
merged 5 commits into from
Oct 12, 2021
Merged

KEP-2907: secrets store csi driver #2939

merged 5 commits into from
Oct 12, 2021

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Sep 2, 2021 •
edited
Loading

  • One-line PR description: A retroactive KEP for the secrets-store-csi-driver project targeting a 1.0 GA release.
  • Other comments:

This PR adds:

  • the retroactive KEP for the secrets-store-csi-driver sig-auth subproject
  • PRR for graduation to GA

After this PR to add the KEP is merged we'll cut a v1.0.0 stable release for the driver. Post release, we'll open a PR to update the stage to stable in the kep.yaml.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Sep 2, 2021
@aramase
Copy link
Member

aramase commented Sep 2, 2021

/cc @ritazh @enj

@aramase
Copy link
Member

aramase commented Sep 2, 2021

/cc @mikedanese

ritazh
ritazh reviewed Sep 21, 2021
View reviewed changes
keps/sig-auth/2907-secrets-store-csi-driver/README.md
-->

###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure in pod creation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we can get a time-series metric for that from the kubelet or the kube-apiserver, but some kubelet measurement of failed volume mounts would be useful as there is an error mode where the request does not make it to the driver process because of issues registering the driver with the kubelet.

We could maybe use kubectl get events --field-selector="reason=FailedMount" --all-namespaces but that can be hard to monitor and there does not appear to be an event for successful Mount operations.

@aramase
review feedback
cae255b 
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase
add liveness-probe to SLI
e151564 
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase
Copy link
Member

aramase commented Oct 5, 2021

After the discussion in the last sig-auth call, we have promoted our crds to v1 and release v1.0.0-rc.1.

@mikedanese @ritazh This KEP should be ready for another round of review. Once this has lgtm + approve we'll be able to cut a v1.0.0 release for the driver.

cc @tam7t

@aramase
Copy link
Member

aramase commented Oct 5, 2021

This PR adds:

  • the retroactive KEP for the secrets-store-csi-driver sig-auth subproject
  • PRR for graduation to GA

After this PR to add the KEP is merged we'll cut a v1.0.0 stable release for the driver. Post release, we'll open a PR to update the stage to stable in the kep.yaml.

@ritazh
Copy link
Member

ritazh commented Oct 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
pohly
pohly reviewed Oct 7, 2021
View reviewed changes
keps/sig-auth/2907-secrets-store-csi-driver/README.md
- Supports windows containers (Kubernetes version v1.18+)
- [KEP 1855: Service Account Token for CSI Driver](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1855-csi-driver-service-account-token)

The driver uses CSI Inline Volumes to mount the external secrets-store objects in the pod. The CSI Inline Volumes feature is enabled by default in Kubernetes 1.16+. For windows containers, the CSI Inline Volumes feature is enabled by default in Kubernetes 1.18+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that's correct, the feature is still only in beta and API changes are needed before it can be promoted. That has stalled due to a lack of volunteers to work on the feature.

You probably should turn this into a dependency on #596

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for pointing that out!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2021
@tam7t tam7t requested a review from mikedanese October 8, 2021 20:38
@mikedanese
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, tam7t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit f140b05 into kubernetes:master Oct 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 12, 2021
@tam7t tam7t deleted the tam7t/secrets-csi-kep branch October 12, 2021 15:32
This was referenced Oct 13, 2021
Closed
Closed
@spiffxp
Copy link
Member

spiffxp commented Oct 13, 2021

This didn't actually go through PRR

@spiffxp spiffxp mentioned this pull request Oct 13, 2021
Merged
@spiffxp
Copy link
Member

spiffxp commented Oct 13, 2021

/cc @ehashman @johnbelamaric @deads2k @wojtek-t

@spiffxp
Copy link
Member

spiffxp commented Oct 13, 2021

I've added a PRR file in #3007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@ritazh ritazh ritazh left review comments

@pohly pohly pohly left review comments

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

@enj enj Awaiting requested review from enj

@mikedanese mikedanese Awaiting requested review from mikedanese

@ehashman ehashman Awaiting requested review from ehashman

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mikedanese mikedanese

@ritazh ritazh

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
7 participants
@tam7t @aramase @ritazh @mikedanese @k8s-ci-robot @spiffxp @pohly