Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSGroup CSI delegation KEP: update metadata, update feature gate name to the latest version #2949

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

verult
Copy link
Contributor

@verult verult commented Sep 7, 2021

  • One-line PR description: update KEP metadata for beta; update feature gate name to the latest version
  • Other comments:

/assign @gnufied @salaxander
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2021
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Sep 7, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2021
@gnufied
Copy link
Member

gnufied commented Sep 7, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: verult, xing-yang
To complete the pull request process, please assign deads2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9ecd0a0 into kubernetes:master Sep 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 7, 2021
@msau42
Copy link
Member

msau42 commented Sep 7, 2021

Hm how did this merge without prr approval?

@verult
Copy link
Contributor Author

verult commented Sep 7, 2021

The corresponding PRR PR containing everything here also merged, that might've been why: #2941

@xing-yang
Copy link
Contributor

Yes, #2941 includes the commit from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants