Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-1491: set latest milestone for vSphere migration to 1.26 #3513

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Sep 14, 2022

  • One-line PR description:
    set latest milestone for vSphere migration to 1.26
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Sep 14, 2022
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2022
@divyenpatel divyenpatel force-pushed the set-vsphere-migration-latest-milestone-k8s-1.26 branch from e892782 to 5d16085 Compare September 14, 2022 21:14
@xing-yang
Copy link
Contributor

@divyenpatel divyenpatel force-pushed the set-vsphere-migration-latest-milestone-k8s-1.26 branch from 5d16085 to 090abcc Compare September 14, 2022 21:36
@divyenpatel
Copy link
Member Author

@xing-yang
Copy link
Contributor

/assign @gnufied @jingxu97

@kikisdeliveryservice kikisdeliveryservice changed the title set latest milestone for vSphere migration to 1.26 KEP-1491: set latest milestone for vSphere migration to 1.26 Sep 16, 2022
@kikisdeliveryservice
Copy link
Member

@divyenpatel For future PRs in this repo, don't forget to include the kep number in the title of the PR and the Issue Link in the PR template. I've updated both for you. :)

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@xing-yang
Copy link
Contributor

/assign @wojtek-t
for PRR review

Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment - I'm fine with the PRR itself.

keps/prod-readiness/sig-storage/1491.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@wojtek-t
Copy link
Member

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, wojtek-t, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 426c6d7 into kubernetes:master Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants