-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1491: set latest milestone for vSphere migration to 1.26 #3513
KEP-1491: set latest milestone for vSphere migration to 1.26 #3513
Conversation
e892782
to
5d16085
Compare
Can you also update this file: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/1491.yaml |
5d16085
to
090abcc
Compare
Done. |
@divyenpatel For future PRs in this repo, don't forget to include the kep number in the title of the PR and the Issue Link in the PR template. I've updated both for you. :) |
/lgtm |
/assign @wojtek-t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment - I'm fine with the PRR itself.
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, wojtek-t, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
set latest milestone for vSphere migration to 1.26