KEP-3685: Move EndpointSlice Reconciler into Staging

[akhilles]

• One-line PR description: Move EndpointSlice Reconciler into Staging
• Issue link: Move EndpointSlice Reconciler into Staging #3685

[k8s-ci-robot]

Welcome @akhilles!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @akhilles. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

/ok-to-test

[astoycos]

/cc

This and #3649 should have some overlap since they're both proposing the moving of core code into staging

[robscott]

/cc

[aojea]

/lgtm

just moving code around so can be easily imported 👍

[robscott]

Thanks @akhilles! Mostly LGTM, just a few tiny nits.

[robscott]

Thanks @akhilles!

/lgtm
/assign @thockin

[shaneutt]

/cc

[thockin]

If rob is LGTM, I will approve

/approve

[thockin]

The cost of moving to staging is increased API durability and scrutiny. If we tell people it is OK to use, we are promising not to break them.

I'd like to use this process to see if there's a way NOT to have "util" packages. Looking at these, most of them should either be internal/... or in the main staging repo directly, or in some properly-designed sub-pkg of this staging repo.

[akhilles]

Agreed, we should avoid the "util" package. It's explicitly called out in the coding conventions doc as well:

Avoid general utility packages. Packages called "util" are suspect.

A combination of copying small functions (+ making them private) and moving others into the main package seems reasonable to me. I'll cover this as part of the public API doc.

[thockin]

or just copied - copying a small function is not forbidden.

[thockin]

same

[thockin]

We SAY this, but we also hold staging to a higher bar than k/k, so I will ask for a thorough re-examination of the API in terms of supportability and docs and quality.

[akhilles]

Ack, I'll draft a doc that evaluates the public API (+ any proposed changes) and send it out for review. I think a lot of the value of this KEP can be realized with a very small public API.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilles, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/sig-network/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment