Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker release notes for 1.8 #408

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Add Docker release notes for 1.8 #408

merged 1 commit into from
Aug 31, 2017

Conversation

yguo0905
Copy link
Contributor

Release notes for Docker 1.13 (17.03) validation in kubernetes/kubernetes#42926.

/assign @dchen1107
/assign @radhikapc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2017
dchen1107
dchen1107 reviewed Aug 31, 2017
View reviewed changes
release-1.8/release_notes_draft.md Outdated
the workaround.
- The support for the v1 registries has been removed.
- Docker version 1.12.6 known issues
- Overlay2 is not supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Overlay2 is not supported for docker 1.12.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supported in Docker but we haven't validated it in k8s. How about "overlay2 has not been validated for Docker 1.12.6"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "supported" means "qualified to use in k8s", and it's misleading.

dchen1107
dchen1107 reviewed Aug 31, 2017
View reviewed changes
release-1.8/release_notes_draft.md Outdated
- The support for the v1 registries has been removed.
- Docker version 1.12.6 known issues
- Overlay2 is not supported
- Live-restore is not supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is supported by docker 1.12.6, but we found some bugs. The statement is misleading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any issues with live-restore. What bugs are you referring to?

dchen1107
dchen1107 reviewed Aug 31, 2017
View reviewed changes
release-1.8/release_notes_draft.md Outdated
- Docker version 1.12.6 known issues
- Overlay2 is not supported
- Live-restore is not supported
- Shared pid namespace is not support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. We should include the bug, instead of saying docker 1.12.6 doesn't support shared pid namespace.

dchen1107
dchen1107 reviewed Aug 31, 2017
View reviewed changes
release-1.8/release_notes_draft.md Outdated

- Docker versions 1.11.2, 1.12.6, 1.13.1 (17.03.2) have been validated
- Docker version 1.13.1 (17.03.2) [#42926](https://github.com/kubernetes/kubernetes/issues/42926)
- Shared PID namespace, live-restore and overlay2 are supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this statement or restate like: "Share PID namespace, .... are validated"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we normally only include the known issue for each docker release we found during the qualification process. I think there is no need to have above sentence here.

radhikapc
radhikapc suggested changes Aug 31, 2017
View reviewed changes
release-1.8/release_notes_draft.md Outdated
Continuous integration builds have used the following versions of external
dependencies, however, this is not a strong recommendation and users should
consult an appropriate installation or upgrade guide before deciding what
versions of etcd, docker or rkt to use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuous integration builds have used Docker versions 1.11.2, 1.12.6, and 1.13.1 (17.03.2). These versions have been validated on Kubernetes 1.8. However, consult an appropriate installation or upgrade guide before deciding what versions of docker to use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: In this section, we are not talking about etcd or rkt. So, can we remove those references and focus only on docker ? cc @calebamiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have them removed. But whoever works on that should add the appropriate information here.

release-1.8/release_notes_draft.md Outdated
consult an appropriate installation or upgrade guide before deciding what
versions of etcd, docker or rkt to use.

- Docker versions 1.11.2, 1.12.6, 1.13.1 (17.03.2) have been validated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what's in the bracket : 17.03.2

Can we remove this item from the list and add to the paragraph ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17.03.2 is a patch version of 1.13, but I changed this to list it separately.

release-1.8/release_notes_draft.md Outdated
- Docker version 1.11.2 known issues
- kernel crash with Aufs storage driver on Debian Jessie (#27885) which can be identified by the node problem detector
- Leaked File descriptors (#275)
- Additional memory overhead per container (#21737)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Docker version 1.13.1 (17.03.2) #42926

    • Features
      * Shared PID namespace, live-restore, and overlay2 are supported.
      * The support for the v1 registries has been removed.
    • Known issues
      * The default iptables FORWARD policy has been changed from ACCEPT to DROP, which causes outbound container traffic to stop functioning. See #40182 for the workaround.

  • Docker version 1.12.6

    • Features
      * None
    • Known issues
      * Overlay2 is not supported
      * Live-restore is not supported
      * Shared pid namespace is not support

  • Docker version 1.11.2

    • Features
      * None
    • Known issues
      * kernel crashes with Aufs storage driver on Debian Jessie (#27885). This issue can be identified by the node problem detector
      * Leaked File descriptors (Add support for pre-allocated hugepages #275)
      * Additional memory overhead per container (#21737)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also provide a descriptive info on leaked file descriptors ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the link.

@jgoclawski jgoclawski mentioned this pull request Aug 31, 2017
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2017
@yguo0905
Copy link
Contributor Author

@dchen1107 and @radhikapc, PTAL. I've updated the release notes per both of your comments.

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2017
radhikapc
radhikapc approved these changes Aug 31, 2017
View reviewed changes
Copy link
Contributor

@radhikapc radhikapc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radhikapc radhikapc merged commit 4c69fa3 into kubernetes:master Aug 31, 2017
@yguo0905 yguo0905 deleted the docker-release-notes branch August 31, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 dchen1107 left review comments

@radhikapc radhikapc radhikapc approved these changes

Assignees

@radhikapc radhikapc

@dchen1107 dchen1107

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yguo0905 @dchen1107 @radhikapc @k8s-ci-robot