add todos

pkg/annotations/service.go

@@ -75,7 +75,11 @@ type ExposeNegAnnotation map[int32]NegAttributes
 
 // NegAttributes houses the attributes of the NEGs that are associated with the
 // service. Future extensions to the Expose NEGs annotation should be added here.
-type NegAttributes struct{}
+type NegAttributes struct {
+	// Note - in the future, this will be used for custom naming of NEGs.
+	// Currently has no effect.
+	Name string `json:"name,omitempty"`
+}
 
 // AppProtocol describes the service protocol.
 type AppProtocol string

pkg/neg/controller_test.go

@@ -303,7 +303,8 @@ func TestGatherPortMappingUsedByIngress(t *testing.T) {
 
 func TestSyncNegAnnotation(t *testing.T) {
 	t.Parallel()
-
+	// TODO: test that c.serviceLister.Update is called whenever the annotation
+	// is changed. When there is no change, Update should not be called.
 	controller := newTestController(fake.NewSimpleClientset())
 	defer controller.stop()
 	controller.serviceLister.Add(newTestService(false, []int32{}))