Merge pull request #436 from rramkumar1/patch-17

Fix error handling in controller sync()
kubernetes · Aug 15, 2018 · e880762 · e880762
2 parents 274a1e5 + 3ef375e
commit e880762
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go
@@ -258,7 +258,7 @@ func (lbc *LoadBalancerController) Stop(deleteAll bool) error {
 }
 
 // sync manages Ingress create/updates/deletes
-func (lbc *LoadBalancerController) sync(key string) (retErr error) {
+func (lbc *LoadBalancerController) sync(key string) error {
 	if !lbc.hasSynced() {
 		time.Sleep(context.StoreSyncPollPeriod)
 		return fmt.Errorf("waiting for stores to sync")
@@ -303,7 +303,7 @@ func (lbc *LoadBalancerController) sync(key string) (retErr error) {
 	// it could have been caused by quota issues; therefore, garbage collecting now may
 	// free up enough quota for the next sync to pass.
 	if gcErr := lbc.gc(lbNames, gceSvcPorts); gcErr != nil {
-		retErr = fmt.Errorf("error during sync %v, error during GC %v", retErr, gcErr)
+		glog.Errorf("error during end-of-sync GC %v", gcErr)
 	}
 
 	return ensureErr