Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle health-check not found error gracefully #1058

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Handle health-check not found error gracefully #1058

merged 1 commit into from
Mar 26, 2020

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Mar 26, 2020 •
edited
Loading

Return after deleting regional health-checks and not try to delete global health checks.

Results in the following error and the ILB gets re-queued,

I0325 09:31:12.089142       1 healthchecks.go:310] Deleting health check k8s1-0cf92254-test-sandbox-7ca3ebc1bfe2ffbd-svc-1-80-54141625
E0325 09:31:12.308709       1 taskqueue.go:62] Requeuing "test-sandbox-7ca3ebc1bfe2ffbd/ing1-1" due to error: error running backend garbage collection routine: error GCing regional Backends: googleapi: Error 404: The resource 'projects/gke-test-ingress-11/global/healthChecks/k8s1-0cf92254-test-sandbox-7ca3ebc1bfe2ffbd-svc-1-80-54141625' was not found, notFound (ingresses)

Also, ignore health-check not found errors.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2020
@skmatti skmatti changed the title Handle health check not found error gracefully Handle health-check not found error gracefully Mar 26, 2020
@skmatti
Copy link
Contributor Author

skmatti commented Mar 26, 2020

/assign @freehan @bowei

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2020
@bowei
Copy link
Member

bowei commented Mar 26, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2020
freehan
freehan reviewed Mar 26, 2020
View reviewed changes
pkg/healthchecks/healthchecks.go Outdated Show resolved Hide resolved
pkg/healthchecks/healthchecks.go Outdated
@@ -305,13 +306,15 @@ func (h *HealthChecks) Delete(name string, scope meta.KeyType) error {
klog.V(4).Infof("DeleteRegionalHealthCheck(%s, _): %v, ignorable error", name, err)
return nil
}
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spencerhance can you double check if we want to return here. It should right?

@freehan
Copy link
Contributor

freehan commented Mar 26, 2020

LGTM
waiting for one more pair of eyes.

@bowei
Copy link
Member

bowei commented Mar 26, 2020

Can you add some test cases?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 15843ee into kubernetes:master Mar 26, 2020
skmatti added a commit to skmatti/ingress-gce that referenced this pull request Mar 26, 2020
@skmatti
Cherrypick kubernetes#1058[Handle health check not found error gracef…
733da3e 
…ully] into release-1.9
k8s-ci-robot added a commit that referenced this pull request Mar 26, 2020
@k8s-ci-robot
Merge pull request #1060 from skmatti/hc-fix
325af47 
Cherrypick #1058[Handle health check not found error gracefully] into release-1.9
@skmatti skmatti deleted the patch-1 branch May 12, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan left review comments

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmatti @k8s-ci-robot @bowei @freehan