Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail ingress creation if specified staticIP name does not exist #1080

Merged
merged 2 commits into from
May 15, 2020

Conversation

prameshj
Copy link
Contributor

The current behavior is to create a different staticIP and use that in the forwarding rule. Once the user-specified ip becomes available, the forwarding rule ip will flip to using that, causing some downtime.

With this change, ingress creation will fail and retry until the user-specified IP has been created out of band.

@spencerhance

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2020
Copy link
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prameshj
Copy link
Contributor Author

/assign @bowei

@bowei
Copy link
Member

bowei commented Apr 29, 2020

is it possible to dig around to see what the context was for the original behavior/

git log -S "doesn't translate to an existing global static IP"
git log -G "doesn't translate to an existing global static IP"

@prameshj
Copy link
Contributor Author

prameshj commented Apr 29, 2020

git log -S "doesn't translate to an existing global static IP"

This was introduced in 3ee943d and has not changed much other than being moved to a different file in db96b94

The comment in the original change states:

//	- We create a forwarding rule with the given IP.
//		- If this ip doesn't exist in GCE, we create another one in the hope
//		  that they will rectify it later on.

@bowei
Copy link
Member

bowei commented May 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2020
@bowei
Copy link
Member

bowei commented May 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants