-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail ingress creation if specified staticIP name does not exist #1080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign @bowei |
is it possible to dig around to see what the context was for the original behavior/ git log -S "doesn't translate to an existing global static IP" |
This was introduced in 3ee943d and has not changed much other than being moved to a different file in db96b94 The comment in the original change states:
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The current behavior is to create a different staticIP and use that in the forwarding rule. Once the user-specified ip becomes available, the forwarding rule ip will flip to using that, causing some downtime.
With this change, ingress creation will fail and retry until the user-specified IP has been created out of band.
@spencerhance