Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce flag endpoint #121

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Feb 2, 2018

This endpoint currently prints the version and current verbosity level. You can also change the verbosity during runtime with a simple PATCH.

curl -X PUT http://localhost:8080/flag?v=10

More information can be added later.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2018
@bowei
Copy link
Member

bowei commented Feb 5, 2018

We should call this endpoint /flag.

@bowei
Copy link
Member

bowei commented Feb 5, 2018

And have debug status show up on /debug

@nicksardo nicksardo changed the title Introduce debug endpoint Introduce flag endpoint Feb 6, 2018
@nicksardo
Copy link
Contributor Author

Renamed to 'flag'. PTAL

@nicksardo nicksardo requested a review from bowei February 7, 2018 01:11
@bowei bowei merged commit f992df2 into kubernetes:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants