Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build #15

Merged
merged 4 commits into from
Oct 11, 2017
Merged

Update build #15

merged 4 commits into from
Oct 11, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Oct 11, 2017

Look at the commits for review. The Makefile and rules.mk are from kube-dns and support a clean build environment with multi architectures.

The standard k8s projects have been following is to put library code in pkg/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2017
@bowei bowei requested a review from nicksardo October 11, 2017 07:29
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 11, 2017
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2017
@nicksardo nicksardo merged commit f48a24a into kubernetes:master Oct 11, 2017
@@ -1,18 +1,44 @@
all: push
# Copyright 2016 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 2017?

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

@G-Harmon you have the power...to make pull requests :-)

@bowei bowei deleted the update-build branch December 23, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants