Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ingress HTTP2 feature gate #161

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Add Ingress HTTP2 feature gate #161

merged 1 commit into from
Apr 4, 2018

Conversation

agau4779
Copy link
Contributor

Feature gate for #146

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2018
@agau4779 agau4779 mentioned this pull request Mar 20, 2018
Closed
@agau4779
Copy link
Contributor Author

/assign freehan

@agau4779 agau4779 closed this Mar 20, 2018
@agau4779 agau4779 deleted the http2featureflag branch March 20, 2018 22:39
@agau4779 agau4779 restored the http2featureflag branch March 20, 2018 23:58
@agau4779 agau4779 reopened this Mar 20, 2018
@dims
Copy link
Member

dims commented Mar 23, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2018
@bowei
Copy link
Member

bowei commented Apr 3, 2018

/assign bowei

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2018
@bowei
Copy link
Member

bowei commented Apr 3, 2018 •
edited
Loading

Preferable would be have a func + global in package flags so we don't have to thread the flags individually through all of the related functions:

type Features struct {
 BackendHTTP2 bool
}
// DefaultFeatures can be stubbed out for unit testing.
var DefaultFeatures = &Features{
 BackendHTTP2: true,
}

func EnabledFeatures() *Features {
 return DefaultFeatures;
}

bowei
bowei reviewed Apr 3, 2018
View reviewed changes
pkg/flags/flags.go Outdated
F.Features = EnabledFeatures()
}

// Ingress feature flags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Features is

pkg/flags/flags.go Outdated

// Ingress feature flags
type Features struct {
Http2 bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Http2 enables ...

@freehan
Copy link
Contributor

freehan commented Apr 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2018
@freehan freehan merged commit d01459c into kubernetes:master Apr 4, 2018
@agau4779 agau4779 deleted the http2featureflag branch February 6, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

Assignees

@bowei bowei

@freehan freehan

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agau4779 @dims @bowei @freehan @k8s-ci-robot