Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify reporting error metrics from L4 RBS services - only report service in error if resync deadline elapsed #1699

Merged
merged 1 commit into from
May 31, 2022
Merged

Modify reporting error metrics from L4 RBS services - only report service in error if resync deadline elapsed #1699

merged 1 commit into from
May 31, 2022

Conversation

kl52752
Copy link
Contributor

@kl52752 kl52752 commented Apr 15, 2022 •
edited
Loading

Add resync timestamp to service metric state

When service sync ends with an error we wants to try to resync it for
some period of time and after that time if result is still error we will
increment L4NetLBSInError metric.

Retry period is fixed 20min. It is becasue resync period is 10min.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kl52752. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2022
@kl52752 kl52752 force-pushed the metric-with-retry branch 2 times, most recently from 61fab3b to 7d38571 Compare April 15, 2022 17:18
@kl52752
Copy link
Contributor Author

kl52752 commented Apr 15, 2022

/assign @freehan

@kl52752
Copy link
Contributor Author

kl52752 commented Apr 15, 2022

/assign @cezarygerard

@k8s-ci-robot
Copy link
Contributor

@kl52752: GitHub didn't allow me to assign the following users: cezarygerard.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @cezarygerard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cezarygerard
cezarygerard reviewed Apr 19, 2022
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/types.go Outdated Show resolved Hide resolved
@kl52752 kl52752 changed the title Metric with retry Modify reporting error metrics from L4 RBS services - only report service in error if resync deadline elapsed Apr 19, 2022
@cezarygerard
Copy link
Contributor

/assign @bowei

@kl52752
Copy link
Contributor Author

kl52752 commented Apr 19, 2022

/assign @bowei

@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@cezarygerard: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bowei
Copy link
Member

bowei commented Apr 21, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2022
bowei
bowei reviewed Apr 27, 2022
View reviewed changes
pkg/metrics/l4metrics_test.go Outdated Show resolved Hide resolved
pkg/flags/flags.go Outdated Show resolved Hide resolved
pkg/l4lb/l4netlbcontroller.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@kl52752 kl52752 requested a review from bowei April 27, 2022 17:34
@cezarygerard
Copy link
Contributor

@bowei ping we need this PR for RBS launch

@kl52752
Copy link
Contributor Author

kl52752 commented May 12, 2022

@bowei all comments are resolved PTAL

bowei
bowei reviewed May 17, 2022
View reviewed changes
pkg/flags/flags.go Outdated Show resolved Hide resolved
pkg/l4lb/l4netlbcontroller.go Outdated Show resolved Hide resolved
pkg/loadbalancers/l4netlb.go Outdated Show resolved Hide resolved
@kl52752 kl52752 requested a review from bowei May 17, 2022 11:31
@kl52752 kl52752 closed this May 17, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2022
@kl52752 kl52752 reopened this May 17, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2022
@kl52752 kl52752 requested a review from bowei May 31, 2022 06:16
@cezarygerard
Copy link
Contributor

/retest

@bowei
Copy link
Member

bowei commented May 31, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cezarygerard, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 434b718 into kubernetes:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezarygerard cezarygerard cezarygerard left review comments

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kl52752 @k8s-ci-robot @cezarygerard @bowei @freehan