Handle L4 ELB RBS controller race with legacy on service creation #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
panslava
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
panslava
force-pushed
the
prevent-target-pool-to-rbs-migration
branch
from
ac79093
to
9294966
Compare
panslava
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
panslava
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
panslava
force-pushed
the
prevent-target-pool-to-rbs-migration
branch
2 times, most recently
from
9a2e73f
to
bc31081
Compare
panslava
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
panslava
force-pushed
the
prevent-target-pool-to-rbs-migration
branch
2 times, most recently
from
ad8cfa1
to
f165d9f
Compare
Clean up RBS resources if we found rbs finalizer and target pool attached to the service
panslava
force-pushed
the
prevent-target-pool-to-rbs-migration
branch
from
f165d9f
to
fb48205
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up RBS resources if we found rbs finalizer and target pool
attached to the service
This expected to only happen during service creation, if user quickly adds rbs annotation after creating the legacy service, before target pool was provisioned