Add checking for firewall source ranges in l4_test #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign kl52752 |
kl52752
reviewed
Sep 15, 2022
pkg/loadbalancers/l4_test.go
Outdated
| return verifyFirewall(l4, nodeNames, fwName, fwDesc) | ||
| sourceRanges, err := servicehelper.GetLoadBalancerSourceRanges(l4.Service) | ||
| if err != nil { | ||
| return fmt.Errorf("servicehelper.GetLoadBalancerSourceRanges(%v) returned error %v, want nil", l4.Service, err) |
There was a problem hiding this comment.
you can add %+v for l4.Service to print fields also, but maybe only namespace name of the service is needed here?
There was a problem hiding this comment.
Thank you, added printing fields
I like being more "verbose" in test, especially on errors, so for me printing whole service is not that bad :)
kl52752
reviewed
Sep 15, 2022
panslava
force-pushed
the
l4_test-firewall-source-ranges
branch
from
e01eb74
to
549e37f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking that len(firewall.SourceRanges) != 0 check that it actually has expected ranges