Use namer.L4Firewall and namer.L4Backend instead of servicePort #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
kl52752
reviewed
Sep 27, 2022
|
|
||
| name := l4netlb.ServicePort.BackendName() | ||
| bsName := l4netlb.namer.L4Backend(l4netlb.Service.Namespace, l4netlb.Service.Name) |
There was a problem hiding this comment.
Is ServicePort used after this refactoring? If not maybe you should delete it.
There was a problem hiding this comment.
Thank you, good catch, done,
but it needed to move a bit of logic upper to l4netlbcontroller, so now it's also changed
panslava
force-pushed
the
firewall-namer-l4netlb
branch
from
f97c236
to
0d15938
Compare
panslava
force-pushed
the
firewall-namer-l4netlb
branch
from
0d15938
to
221d825
Compare
|
/assign cezarygerard |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to have single source of naming, which is L4Namer in l4netlb
This PR changes getting Backend Service name and Firewall name with using namer, instead of ServicePort
This PR also helps to add DualStack implementation
/assign @kl52752