NetLB controller: cleanup RBS resources in case service type changed #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue, that on switching Service Type from LoadBalancer to ClusterIP or NodePort RBS resources were not cleaned up
…ogic 1) only process if old or new version of the service was/is RBS 2) only delete if service has RBS annotation/finalizer/forwarding rule, even if the type changed from LoadBalacer to other 3) added 2 test cases for service type change (external name, empty value)
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
cezarygerard
changed the title
cezarygerard
changed the title
|
Good job in saving up on calls! /lgtm unhold when you think we are ready to merge |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold let's merge |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetLB RBS Controller: Change needsDeletion and shouldProcessService logic
This will make controller cleanup RBS resources in case service type changed.
This PR builds on top of pull/1879 from @panslava