Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to validate error states are detected #2028

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Add unit tests to validate error states are detected #2028

merged 4 commits into from
Jun 8, 2023

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Mar 21, 2023 •
edited
Loading

Add TestParseEndpointBatchErr to verify invalid endpoint batch error state. Add TestValidateEndpointFields to verify invalid endpoint information error state.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2023
@sawsa307 sawsa307 changed the title Add TestValidateEndpointBatch to verify invalid endpoint batch error states Verify invalid endpoint batch error states Mar 21, 2023
@sawsa307
Copy link
Contributor Author

/assign @swetharepakula

@sawsa307 sawsa307 changed the title Verify invalid endpoint batch error states Add unit test for invalid endpoint batch error states Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2023
sawsa307 added a commit to sawsa307/ingress-gce that referenced this pull request Mar 22, 2023
@sawsa307
kubernetes#2028
ffcf8c0
@sawsa307
Copy link
Contributor Author

/assign @bowei

sawsa307 added a commit to sawsa307/ingress-gce that referenced this pull request Mar 23, 2023
@sawsa307
kubernetes#2028
0c63018
sawsa307 added a commit to sawsa307/ingress-gce that referenced this pull request Mar 23, 2023
@sawsa307
kubernetes#2028
31f9fbf
@sawsa307 sawsa307 changed the title Add unit test for invalid endpoint batch error states Add unit tests to validate error states are detected Mar 29, 2023
@sawsa307 sawsa307 force-pushed the add-tests-negapi-error branch 6 times, most recently from cefd23f to f80f542 Compare March 30, 2023 17:35
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 2, 2023
@sawsa307
Copy link
Contributor Author

sawsa307 commented May 2, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
swetharepakula
swetharepakula reviewed Jun 1, 2023
View reviewed changes
pkg/neg/syncers/transaction_test.go Outdated
_, transactionSyncer := newTestTransactionSyncer(fakeCloud, negtypes.VmIpPortEndpointType, false)

err := transactionSyncer.cloud.AttachNetworkEndpoints(transactionSyncer.NegSyncerKey.NegName, zone, networkEndpoints, transactionSyncer.NegSyncerKey.GetAPIVersion())
err = checkEndpointBatchErr(err, tc.endpointOperation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not directly pass in the return error here?

Why do we need the transaction syncer and the mock attachnetwork endpoint hook?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Updated.

pkg/neg/syncers/utils_test.go Outdated
expectErr: nil,
},
{
desc: "include one endpoint that does correspond to an existing node",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: does not correspond

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

pkg/neg/syncers/utils_test.go Outdated
},
expectSets: nil,
expectMap: nil,
expectErr: negtypes.ErrEPZoneMissing,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be ErrEPNodeNotFound ?

Copy link
Contributor Author

@sawsa307 sawsa307 Jun 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Updated.
We get zone information from zoneGetter, which basically list all the nodes, look for the matching one, and extract its zone information.

@swetharepakula
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2023
swetharepakula
swetharepakula reviewed Jun 7, 2023
View reviewed changes
pkg/neg/syncers/transaction.go Outdated
s.syncLock.Lock()
s.logger.V(3).Info("Updating error state", "error state", syncErr.Reason)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should you remove the V(3) here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

swetharepakula
swetharepakula reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, otherwise LGTM

pkg/neg/syncers/utils.go Show resolved Hide resolved
swetharepakula
swetharepakula reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, otherwise LGTM

swetharepakula
swetharepakula reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawsa307, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit e83abbd into kubernetes:master Jun 8, 2023
@sawsa307 sawsa307 deleted the add-tests-negapi-error branch September 2, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

Assignees

@bowei bowei

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @swetharepakula @bowei