run presubmits with pull-request created image #2029

aojea · 2023-03-21T15:43:52Z

See if we can detect problems before merging

aojea · 2023-03-21T15:44:06Z

/hold
/test pull-ingress-gce-e2e

aojea · 2023-03-21T16:38:00Z

/test pull-ingress-gce-e2e

aojea · 2023-03-21T17:09:25Z

/hold cancel

aojea · 2023-03-21T17:10:53Z

/assign @gauravkghildiyal

LGTM to get the presubmit job working, so we can keep debugging the problem, right now is failing with

 Mar 21 16:51:20.857: INFO: Retrieving UID from config map: kube-system/ingress-uid
  Mar 21 16:51:20.900: INFO: Unexpected error: 
      <*errors.StatusError | 0xc0002bf900>: 
      configmaps "ingress-uid" not found
      {
          ErrStatus: 
              code: 404
              details:
                kind: configmaps
                name: ingress-uid
              message: configmaps "ingress-uid" not found
              metadata: {}
              reason: NotFound
              status: Failure,
      }
  [FAILED] in [BeforeEach] - test/e2e/network/ingress.go:100 @ 03/21/23 16:51:20.9
  Mar 21 16:51:20.900: INF

k8s-ci-robot · 2023-03-21T17:10:55Z

@aojea: GitHub didn't allow me to assign the following users: gauravkghildiyal.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gauravkghildiyal

LGTM to get the presubmit job working, so we can keep debugging the problem, right now is failing with

Mar 21 16:51:20.857: INFO: Retrieving UID from config map: kube-system/ingress-uid
 Mar 21 16:51:20.900: INFO: Unexpected error: 
     <*errors.StatusError | 0xc0002bf900>: 
     configmaps "ingress-uid" not found
     {
         ErrStatus: 
             code: 404
             details:
               kind: configmaps
               name: ingress-uid
             message: configmaps "ingress-uid" not found
             metadata: {}
             reason: NotFound
             status: Failure,
     }
 [FAILED] in [BeforeEach] - test/e2e/network/ingress.go:100 @ 03/21/23 16:51:20.9
 Mar 21 16:51:20.900: INF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aojea · 2023-03-21T17:25:56Z

/test pull-ingress-gce-e2e

aojea · 2023-03-21T21:39:24Z

/test pull-ingress-gce-e2e

aojea · 2023-03-21T22:16:14Z

/test pull-ingress-gce-e2e

aojea · 2023-03-21T22:52:49Z

/test pull-ingress-gce-e2e

aojea · 2023-03-22T08:31:41Z

/test pull-ingress-gce-e2e

aojea · 2023-03-22T09:33:58Z

/test pull-ingress-gce-e2e

aojea · 2023-03-22T10:06:05Z

/test pull-ingress-gce-e2e

aojea · 2023-03-22T10:27:19Z

/test pull-ingress-gce-e2e

aojea · 2023-03-23T09:41:28Z

/test pull-ingress-gce-e2e

aojea · 2023-03-23T10:34:44Z

ok, finally this went through https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/ingress-gce/2029/pull-ingress-gce-e2e/1638838371042201600

aojea · 2023-03-23T10:44:11Z

/test pull-ingress-gce-e2e

let's see if the image we are building is incorrect, it passed with the nightly one

aojea · 2023-03-23T11:25:14Z

ok, confirmedv the image built with ko is not ok

aojea · 2023-03-23T12:00:32Z

the problem now is that the image built with kois non-root , so it fails to access the files as non-root app, let's see if we can advance with that, is a nice to have thing to be able to run as non-root

aojea · 2023-03-23T12:15:31Z

/test pull-ingress-gce-e2e

aojea · 2023-03-23T12:20:21Z

/test pull-ingress-gce-e2e

aojea · 2023-03-23T15:19:06Z

the problem now is that the image built with kois non-root , so it fails to access the files as non-root app, let's see if we can advance with that, is a nice to have thing to be able to run as non-root

baby steps

  Mar 23 12:44:27.562: INFO: Logs of kube-system/l7-lb-controller-e2e-33e77b4463-7a98c-master:l7-lb-controller on node e2e-33e77b4463-7a98c-master
  Mar 23 12:44:27.562: INFO:  : STARTLOG
  I0323 12:44:17.954137       1 main.go:76] Starting GLBC image: "UNKNOWN", cluster name ""
  log: exiting because of error: log: unable to create log: open /var/log/glbc.log: permission denied

aojea · 2023-03-23T15:35:26Z

/test pull-ingress-gce-e2e

aojea · 2023-03-23T16:31:49Z

/test pull-ingress-gce-e2e

this should be the good one

add a presubmit job that builds the glbc image from current PR and use it for test in a kubernetes cluster Co-authored-by: Gaurav Ghildiyal <[email protected]>

aojea · 2023-03-23T16:47:49Z

/test pull-ingress-gce-e2e

gauravkghildiyal · 2023-03-23T18:26:59Z

Wow it finally worked. Awesome Antonio -- I didn't know that the permission to write logs could be because ko built a non-root image. Nice to learn.

aojea · 2023-03-23T18:30:32Z

Wow it finally worked. Awesome Antonio -- I didn't know that the permission to write logs could be because ko built a non-root image. Nice to learn.

I learnt it today, but all the credit is your, I already gave up until you found the bash thing

aojea · 2023-03-23T19:09:12Z

the e2e teakes too much, I will try to reduce the list

aojea · 2023-03-23T19:14:27Z

/test pull-ingress-gce-e2e

aojea · 2023-03-23T20:24:10Z

/test pull-ingress-gce-e2e

gauravkghildiyal · 2023-03-23T21:03:00Z

Looks good to me
(don't have membership yet for an actual LGTM)

aojea · 2023-03-23T21:17:11Z

it works and runs in 26 minutes

bowei · 2023-03-24T17:55:23Z

/lgtm
/approve

Thanks Antonio!

k8s-ci-robot · 2023-03-24T17:55:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [aojea,bowei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2023-03-24T20:19:06Z

hack/run-e2e-gce.sh

@@ -58,22 +53,113 @@ if [[ -z "${IMAGE_TAG:-}" ]]; then
  IMAGE_TAG=$(git rev-parse --short HEAD)-$(date +%Y%m%dT%H%M%S)
 fi

-export GCE_GLBC_IMAGE=$(go run github.com/google/[email protected] build --tags ${IMAGE_TAG} --base-import-paths --push=true ./cmd/glbc/)
+KO_GLBC_IMAGE=$(go run github.com/google/[email protected] build --tags ${IMAGE_TAG} --base-import-paths --push=true ./cmd/glbc/)


so this pushes to a registry? what GCs these?

This is pushed to the GCR registry in the boskos project. you can see the GCS for GCR created in https://github.com/kubernetes/k8s.io/pull/5015/files for kops tests.

I think we should migrate to regional ARs for each boskos project.

pushes to boskos created project, I copied from @justinsb , that is why I asked, I think this is eventually garbage collected

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023

k8s-ci-robot requested review from code-elinka and kl52752 March 21, 2023 15:43

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 21, 2023

aojea force-pushed the presubmit branch from abbbc94 to d970647 Compare March 21, 2023 15:47

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023

aojea force-pushed the presubmit branch from d970647 to 3199745 Compare March 21, 2023 17:13

aojea changed the title ~~run presubmits with custom image~~ run presubmits with pull-request created image Mar 21, 2023

aojea force-pushed the presubmit branch from 3199745 to 57d7449 Compare March 21, 2023 21:39

aojea force-pushed the presubmit branch from 57d7449 to 46a3c68 Compare March 21, 2023 22:16

aojea force-pushed the presubmit branch from 46a3c68 to 602954c Compare March 21, 2023 22:52

aojea force-pushed the presubmit branch from 602954c to 086cc5b Compare March 22, 2023 08:31

aojea force-pushed the presubmit branch from 086cc5b to 25750d9 Compare March 22, 2023 09:33

aojea force-pushed the presubmit branch from 25750d9 to 9af1050 Compare March 22, 2023 10:05

aojea force-pushed the presubmit branch from 9af1050 to 4933b34 Compare March 22, 2023 10:27

aojea force-pushed the presubmit branch from 322cc90 to aef449c Compare March 23, 2023 12:20

aojea force-pushed the presubmit branch from e5af673 to a0c6a74 Compare March 23, 2023 16:29

run presubmits with custom image

8529f04

add a presubmit job that builds the glbc image from current PR and use it for test in a kubernetes cluster Co-authored-by: Gaurav Ghildiyal <[email protected]>

aojea force-pushed the presubmit branch from a0c6a74 to 8529f04 Compare March 23, 2023 16:34

run tests in parallel

c5ece90

smoke test for presubmits

ebb6058

k8s-ci-robot assigned bowei Mar 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023

k8s-ci-robot merged commit 0e6aced into kubernetes:master Mar 24, 2023

BenTheElder reviewed Mar 24, 2023

View reviewed changes

run presubmits with pull-request created image #2029

run presubmits with pull-request created image #2029

Conversation

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

k8s-ci-robot commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 21, 2023

aojea commented Mar 22, 2023

aojea commented Mar 22, 2023

aojea commented Mar 22, 2023

aojea commented Mar 22, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

/test pull-ingress-gce-e2e

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

gauravkghildiyal commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

aojea commented Mar 23, 2023

gauravkghildiyal commented Mar 23, 2023

aojea commented Mar 23, 2023 • edited Loading

bowei commented Mar 24, 2023

k8s-ci-robot commented Mar 24, 2023

BenTheElder Mar 24, 2023

Choose a reason for hiding this comment

ameukam Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

ameukam Mar 24, 2023

Choose a reason for hiding this comment

aojea Mar 24, 2023

Choose a reason for hiding this comment

aojea commented Mar 23, 2023 •

edited

Loading

ameukam Mar 24, 2023 •

edited

Loading