Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONify healthcheck Description for BackendConfig #2068

Merged
merged 2 commits into from
Apr 27, 2023
Merged

JSONify healthcheck Description for BackendConfig #2068

merged 2 commits into from
Apr 27, 2023

Conversation

DamianSawicki
Copy link
Contributor

@DamianSawicki DamianSawicki commented Apr 5, 2023 •
edited
Loading

Replace a plain string with a JSON string as the health check Description when the health check is configured with a BackendConfig CRD. The longer plan is to similarly JSONify all health check Descriptions, irrespective of the health check configuration.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @DamianSawicki. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2023
kl52752
kl52752 reviewed Apr 6, 2023
View reviewed changes
pkg/backends/syncer.go Outdated Show resolved Hide resolved
pkg/healthchecks/healthchecks.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
pkg/utils/descutils/utils.go Outdated Show resolved Hide resolved
@DamianSawicki DamianSawicki force-pushed the jsonify-HC-desc-for-BC branch 4 times, most recently from 829c504 to 7803d90 Compare April 6, 2023 17:29
@DamianSawicki
Copy link
Contributor Author

No e2e manual tests done yet, but unit tests (existing ones with modifications and some new ones) pass.

@DamianSawicki DamianSawicki marked this pull request as ready for review April 6, 2023 18:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@DamianSawicki
Copy link
Contributor Author

/assign kl52752

kl52752
kl52752 reviewed Apr 7, 2023
View reviewed changes
pkg/healthchecks/healthchecks.go Show resolved Hide resolved
pkg/translator/healthchecks.go Outdated Show resolved Hide resolved
@DamianSawicki DamianSawicki force-pushed the jsonify-HC-desc-for-BC branch 2 times, most recently from a645166 to 80d6346 Compare April 7, 2023 10:17
@kl52752
Copy link
Contributor

kl52752 commented Apr 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2023
@DamianSawicki DamianSawicki force-pushed the jsonify-HC-desc-for-BC branch 3 times, most recently from 0a4292d to 9d454d8 Compare April 7, 2023 14:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
@DamianSawicki
Copy link
Contributor Author

K8sResourceDependency removed as requested by @bowei. Tested as described in the bug-tracking system.

/unassign kl52752
/assign swetharepakula
/cc bowei

@k8s-ci-robot k8s-ci-robot requested a review from bowei April 18, 2023 11:47
@DamianSawicki
Copy link
Contributor Author

I'll change description field names to start with lower-case letters.

@DamianSawicki
Copy link
Contributor Author

I'll change description field names to start with lower-case letters.

Done.

@DamianSawicki
Copy link
Contributor Author

/assign bowei

@DamianSawicki
Copy link
Contributor Author

/unassign bowei

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2023
@kl52752
Copy link
Contributor

kl52752 commented Apr 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4199a36 into kubernetes:master Apr 27, 2023
@DamianSawicki DamianSawicki mentioned this pull request May 2, 2023
Merged
@DamianSawicki DamianSawicki mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kl52752 kl52752 kl52752 left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

@bowei bowei Awaiting requested review from bowei

Assignees

@swetharepakula swetharepakula

@kl52752 kl52752

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DamianSawicki @k8s-ci-robot @kl52752 @swetharepakula @bowei