Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out migrating endpoints in NEG controller #2070

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Filter out migrating endpoints in NEG controller #2070

merged 2 commits into from
Apr 11, 2023

Conversation

gauravkghildiyal
Copy link
Member

@gauravkghildiyal gauravkghildiyal commented Apr 7, 2023 •
edited
Loading

/assign @swetharepakula

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @gauravkghildiyal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 7, 2023
@gauravkghildiyal
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2023
@swetharepakula
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2023
swetharepakula
swetharepakula reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nits. this is almost ready to be merged

pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils_test.go Show resolved Hide resolved
gauravkghildiyal
gauravkghildiyal commented Apr 11, 2023
View reviewed changes
Copy link
Member Author

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

pkg/neg/syncers/utils_test.go Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils_test.go Outdated Show resolved Hide resolved
pkg/neg/syncers/utils_test.go Outdated Show resolved Hide resolved
@gauravkghildiyal gauravkghildiyal mentioned this pull request Apr 11, 2023
Closed
@gauravkghildiyal
Copy link
Member Author

Ready.

swetharepakula
swetharepakula reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit cfc58de into kubernetes:master Apr 11, 2023
@gauravkghildiyal gauravkghildiyal deleted the filter-migrating-endpoints branch April 11, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauravkghildiyal @k8s-ci-robot @swetharepakula