Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code to setup removal of ServicePort logic out of translator #214

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Code to setup removal of ServicePort logic out of translator #214

merged 1 commit into from
Apr 14, 2018

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Apr 12, 2018 •
edited
Loading

A followup PR will modify the controller to use this code rather than the code in pkg/translator.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2018
@rramkumar1 rramkumar1 force-pushed the add-validation branch 3 times, most recently from bc85fe5 to ed70af2 Compare April 12, 2018 23:50
@rramkumar1 rramkumar1 mentioned this pull request Apr 13, 2018
Closed
@rramkumar1
Copy link
Contributor Author

rramkumar1 commented Apr 13, 2018 •
edited
Loading

/assign @nicksardo
For initial thoughts

@rramkumar1 rramkumar1 force-pushed the add-validation branch 5 times, most recently from 1762bde to 47bd849 Compare April 13, 2018 23:17
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2018
@rramkumar1 rramkumar1 force-pushed the add-validation branch 2 times, most recently from 96a7d64 to 52948de Compare April 13, 2018 23:26
@rramkumar1 rramkumar1 changed the title Move retrieval of ServicePort's out of translator and also introduce some new interfaces to fetch resources [WIP] Move retrieval of ServicePort's out of translator and also introduce some new interfaces to fetch resources Apr 13, 2018
@rramkumar1
Copy link
Contributor Author

/retest

@rramkumar1 rramkumar1 changed the title Move retrieval of ServicePort's out of translator and also introduce some new interfaces to fetch resources Code to setup removal of ServicePort's out of translator and also introduce some new interfaces to fetch resources Apr 13, 2018
@rramkumar1 rramkumar1 changed the title Code to setup removal of ServicePort's out of translator and also introduce some new interfaces to fetch resources Code to setup removal of ServicePort logic out of translator Apr 13, 2018
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2018
@nicksardo nicksardo merged commit 69e9e55 into kubernetes:mci-dev Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicksardo nicksardo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rramkumar1 @nicksardo @k8s-ci-robot