Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick #2186] Include proxy-only subnet with purpose=REGIONAL_MANAGED_PROXY when ge… #2188

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Jul 3, 2023

…nerating firewall rules for Ingress

[Cherry-pick #2186]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2023
@aojea
Copy link
Member Author

aojea commented Jul 3, 2023

/assign @gauravkghildiyal @cezarygerard

@aojea aojea changed the title Include proxy-only subnet with purpose=REGIONAL_MANAGED_PROXY when ge… cherry-pick-2186-1.23: Include proxy-only subnet with purpose=REGIONAL_MANAGED_PROXY when ge… Jul 3, 2023
@cezarygerard
Copy link
Contributor

Antonio, please change the title to

[Cherry-pick #2186]

@aojea aojea changed the title cherry-pick-2186-1.23: Include proxy-only subnet with purpose=REGIONAL_MANAGED_PROXY when ge… [Cherry-pick #2186] Include proxy-only subnet with purpose=REGIONAL_MANAGED_PROXY when ge… Jul 3, 2023
@aojea
Copy link
Member Author

aojea commented Jul 3, 2023

Antonio, please change the title to

[Cherry-pick #2186]

done

@aojea aojea changed the base branch from master to release-1.23 July 3, 2023 13:36
@cezarygerard
Copy link
Contributor

/gltm

@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cezarygerard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2092c7c into kubernetes:release-1.23 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants