Use leader election to prevent multiple controllers running #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
nicksardo
force-pushed
the
leader-election
branch
from
31101e0
to
bee0d63
Compare
|
/assign |
nicksardo
changed the title
bowei
reviewed
Jun 1, 2018
cmd/glbc/app/handlers.go
Outdated
| @@ -33,22 +33,19 @@ import ( | |||
| "k8s.io/ingress-gce/pkg/version" | |||
| ) | |||
|
|
|||
| func RunHTTPServer(lbc *controller.LoadBalancerController) { | |||
| func RunHTTPServer(healthcheck func() error) { | |||
There was a problem hiding this comment.
Can you document what the contract is for healthcheck?
cmd/glbc/main.go
Outdated
| healthCheck := func() error { return nil } | ||
| go app.RunHTTPServer(healthCheck) | ||
|
|
||
| run := func() { |
There was a problem hiding this comment.
make this a real method, unless you are heavily using variable capture
cmd/glbc/main.go
Outdated
| go app.RunHTTPServer(lbc) | ||
| go app.RunSIGTERMHandler(lbc, flags.F.DeleteAllOnQuit) | ||
| if !flags.F.LeaderElection.Enabled { | ||
| run() |
cmd/glbc/main.go
Outdated
| } | ||
| // add a uniquifier so that two processes on the same host don't accidentally both become active | ||
| id := fmt.Sprintf("%v_%x", hostname, rand.Intn(1e6)) |
There was a problem hiding this comment.
why not just math.rand.Int64()? Also, why do we have to use the k8s library?
pkg/flags/flags.go
Outdated
| DefaultLockObjectNamespace string = "kube-system" | ||
|
|
||
| // DefaultLockObjectName is the object name of the lock object. | ||
| DefaultLockObjectName = "ingress-gce" |
There was a problem hiding this comment.
ingress-gce-lock? it may be a possibility to use kube-system:ingress-gce for configuration
pkg/flags/flags.go
Outdated
| // Enabled enables a leader election client to gain leadership | ||
| // before executing the main loop. Enable this when running replicated | ||
| // components for high availability. | ||
| Enabled bool |
There was a problem hiding this comment.
Isn't this already a command line flag?
pkg/flags/flags.go
Outdated
| // acquisition and renewal of a leadership. This is only applicable if | ||
| // leader election is enabled. | ||
| RetryPeriod time.Duration | ||
| // ResourceLock indicates the resource object type that will be used to lock |
nicksardo
force-pushed
the
leader-election
branch
from
aa0e0cc
to
00046f4
Compare
k8s-ci-robot
added
size/XXL
nicksardo
force-pushed
the
leader-election
branch
7 times, most recently
from
3f9c401
to
530136d
Compare
k8s-ci-robot
added
the
lgtm
bowei
reviewed
Jun 6, 2018
| status := "OK" | ||
| if result != nil { | ||
| hasErr = true | ||
| status = fmt.Sprintf("err: %v", result) |
There was a problem hiding this comment.
would be easier for the consumer if this was JSON, but let's take it up in a follow up PR
cmd/glbc/main.go
Outdated
| func runControllers(ctx *context.ControllerContext, cloud *gce.GCECloud) { | ||
| namer, err := app.NewNamer(ctx.KubeClient, flags.F.ClusterName, controller.DefaultFirewallName) | ||
| if err != nil { | ||
| glog.Fatalf("%v", err) |
There was a problem hiding this comment.
probably want to put more explication here
glog.Fatalf("app.NewNamer(ctx.KubeClient, %q, %q) = %v", ...)
nicksardo
commented
Jun 6, 2018
pkg/flags/flags.go
Outdated
| LeaseDuration: metav1.Duration{Duration: DefaultLeaseDuration}, | ||
| RenewDeadline: metav1.Duration{Duration: DefaultRenewDeadline}, | ||
| RetryPeriod: metav1.Duration{Duration: DefaultRetryPeriod}, | ||
| ResourceLock: resourcelock.ConfigMapsResourceLock, |
There was a problem hiding this comment.
Making this default a constant
nicksardo
force-pushed
the
leader-election
branch
from
530136d
to
26c99f6
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
nicksardo
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to starting the ingress or neg controllers, the binary will now wait to acquire a resource lock.