Add simple validation for BackendConfig using OpenAPI schema generation #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
force-pushed
the
backend-config-schema-validation
branch
2 times, most recently
from
159cd42
to
bd136cc
Compare
MrHohn
reviewed
May 16, 2018
pkg/backendconfig/crdvalidation.go
Outdated
| *ref = schemaProps.Ref.String() | ||
| } | ||
|
|
||
| props = &extensionsobj.JSONSchemaProps{ |
There was a problem hiding this comment.
Oh interesting...Didn't expect it will look like this in codes :)
There was a problem hiding this comment.
Surprisingly, this is the only way currently to generate the validation spec in code given go structs.
rramkumar1
force-pushed
the
backend-config-schema-validation
branch
2 times, most recently
from
cc46288
to
04df3f5
Compare
rramkumar1
changed the title
MrHohn
reviewed
May 16, 2018
| limitations under the License. | ||
| */ | ||
|
|
||
| // Note: All credit goes to github.com/ant31/crd-validation for this code. |
There was a problem hiding this comment.
A quick comment, should we vendor github.com/ant31/crd-validation instead?
MrHohn
reviewed
May 16, 2018
| @@ -41,7 +41,7 @@ func NewSimpleClientset(objects ...runtime.Object) *Clientset { | |||
| } | |||
| } | |||
|
|
|||
| fakePtr := &testing.Fake{} | |||
There was a problem hiding this comment.
BTW we will need to patch 3af3642 everytime when regenerate this client, or go vet will fail...
I0516 16:21:40.714] # k8s.io/ingress-gce/pkg/backendconfig/client/clientset/versioned/fake
I0516 16:21:40.714] pkg/backendconfig/client/clientset/versioned/fake/clientset_generated.go:56: literal copies lock value from fakePtr: k8s.io/ingress-gce/vendor/k8s.io/client-go/testing.Fake
348227f
to
2fdbed6
Compare
MrHohn
approved these changes
May 17, 2018
cmd/glbc/main.go
Outdated
| @@ -34,7 +34,8 @@ import ( | |||
| neg "k8s.io/ingress-gce/pkg/neg" | |||
|
|
|||
| "k8s.io/ingress-gce/cmd/glbc/app" | |||
| "k8s.io/ingress-gce/pkg/backendconfig" | |||
| backendconfig "k8s.io/ingress-gce/pkg/backendconfig" | |||
pkg/crd/crd.go
Outdated
| if meta.typeSource != "" && meta.fn != nil { | ||
| validationSpec, err := validation(meta.typeSource, meta.fn) | ||
| if err != nil { | ||
| glog.V(0).Infof("Error adding simple validation for %v CRD: %v", meta.kind, err) |
There was a problem hiding this comment.
And maybe remove the word "simple"?
rramkumar1
force-pushed
the
backend-config-schema-validation
branch
from
2fdbed6
to
6271766
Compare
rramkumar1
force-pushed
the
backend-config-schema-validation
branch
from
6271766
to
51b54d2
Compare
rramkumar1
changed the title
|
/assign @nicksardo |
nicksardo
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update codegen scripts to include generation of OpenAPI schema for BackendConfig
Use the generated schema to construct a validation spec which is used to initialize the CRD. If everything works right, when a CR is pushed, the validation spec will kick in and make sure the spec is valid based on the types we have defined for the BackendConfig (pkg/apis/backendconfig/v1beta1/types.go).
Refactor the crd code to be more generic by introducing a CRDMeta type which stores all information needed to build a CRD.
FYI: One of the commits is a vendor update and one is a patch to generated code.
/assign @MrHohn