Add fixtures and helpers in e2e framework for BackendConfig #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
force-pushed
the
backend-config-validator
branch
from
7cdf477
to
5e91da6
Compare
bowei
reviewed
Jun 13, 2018
pkg/fuzz/helpers.go
Outdated
| } | ||
|
|
||
| // ToggleCDN enables or disables CDN on the BackendConfig. | ||
| func (b *BackendConfigBuilder) ToggleCDN(enabled bool) *BackendConfigBuilder { |
pkg/fuzz/helpers.go
Outdated
|
|
||
| // ToggleCDN enables or disables CDN on the BackendConfig. | ||
| func (b *BackendConfigBuilder) ToggleCDN(enabled bool) *BackendConfigBuilder { | ||
| if b.backendConfig.Spec.Cdn == nil { |
There was a problem hiding this comment.
if enabled == false {
b.backendConfig.Spec.Cdn = nil
}
There was a problem hiding this comment.
I'm not following.. if enabled is false, I would want to set Cdn.Enabled to false, not set the pointer to nil.
rramkumar1
force-pushed
the
backend-config-validator
branch
from
5e91da6
to
40ff255
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @bowei
This change is