Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger ingress sync on system default backend update #352

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Trigger ingress sync on system default backend update #352

merged 1 commit into from
Jun 20, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Jun 20, 2018

Given that setting backend config with system default backend is valid, update on system default backend should trigger ingress sync as well.

/assign @rramkumar1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2018
@MrHohn MrHohn force-pushed the default-backend-update branch 2 times, most recently from 42c8a77 to 2cf04b0 Compare June 20, 2018 21:41
@MrHohn
Copy link
Member Author

MrHohn commented Jun 20, 2018

@nicksardo Removed switch case, PTAL thanks!

@MrHohn MrHohn force-pushed the default-backend-update branch 2 times, most recently from b727993 to a86a8ee Compare June 20, 2018 21:50
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2018
@MrHohn
Copy link
Member Author

MrHohn commented Jun 20, 2018

Updated the code a bit..

@MrHohn
Copy link
Member Author

MrHohn commented Jun 20, 2018

Sorry for the noise, unexported defaultBackendSvcPortID.

@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2018
@nicksardo nicksardo merged commit 949c7a8 into kubernetes:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicksardo nicksardo

@rramkumar1 rramkumar1

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrHohn @nicksardo @k8s-ci-robot @rramkumar1