promote http2 to beta #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
MrHohn
reviewed
Jun 29, 2018
pkg/utils/serviceport.go
Outdated
| // The rest are v1 | ||
| func (sp ServicePort) Version() meta.Version { | ||
| if sp.Protocol == annotations.ProtocolHTTP2 { |
There was a problem hiding this comment.
Sorry, this func is being removed by #384. You might need to rebase after that :/
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/assign bowei |
bowei
reviewed
Jul 12, 2018
pkg/healthchecks/healthchecks.go
Outdated
| @@ -399,10 +399,7 @@ func (hc *HealthCheck) isHttp2() bool { | |||
| // Use Alpha API for HTTP2 | |||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that the beta resources are available on GCP compute, and that the k8s e2e http2 test works with these changes.