Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all code related to legacy health checks #418

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Remove all code related to legacy health checks #418

merged 1 commit into from
Aug 14, 2018

Conversation

rramkumar1
Copy link
Contributor

Fixes #269

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2018
@rramkumar1
Copy link
Contributor Author

/assign @bowei
/assign @MrHohn

bowei
bowei reviewed Aug 2, 2018
View reviewed changes
pkg/backends/backends.go Outdated
@@ -195,18 +195,9 @@ func (b *Backends) Get(name string, version meta.Version) (*composite.BackendSer
return be, nil
}

func (b *Backends) ensureHealthCheck(sp utils.ServicePort, hasLegacyHC bool) (string, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we emit a log error if hasLegacyHC is true (still delete the rest of the code)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rramkumar1 rramkumar1 force-pushed the remove-legacy-health-checks branch 2 times, most recently from f7ebd32 to eb4b45b Compare August 3, 2018 23:05
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2018
@bowei
Copy link
Member

bowei commented Aug 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2018
@bowei bowei merged commit 7079695 into kubernetes:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

Assignees

@bowei bowei

@MrHohn MrHohn

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rramkumar1 @bowei @MrHohn @k8s-ci-robot