Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: don't assume instance groups where NEG is an option #533

Merged
merged 1 commit into from
Nov 6, 2018
Merged

README.md: don't assume instance groups where NEG is an option #533

merged 1 commit into from
Nov 6, 2018

Conversation

bpineau
Copy link
Contributor

@bpineau bpineau commented Nov 4, 2018

README.md is light on details related to recent features (NEGs,
BackendConfig, etc.). That may be material for an other PR ?

For now, let's just edit so the content remains correct (ie. not
assuming instance groups exclusively, when NEG is an option).

README.md is light on details related to recent features (NEGs,
BackendConfig, etc.). That may be material for an other PR ?

For now, let's just edit so the content remains correct (ie. not
assuming instance groups exclusively, when NEG is an option).
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2018
@rramkumar1
Copy link
Contributor

/assign @freehan

@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2018
@freehan
Copy link
Contributor

freehan commented Nov 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpineau, freehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 63bd8b9 into kubernetes:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants