Configure leader election with completely separate k8s client #623
Conversation
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
force-pushed
the
leader-elect-new-client
branch
from
186c613
to
0757360
Compare
cmd/glbc/main.go
Outdated
| @@ -83,6 +83,12 @@ func main() { | |||
| glog.Fatalf("Failed to create kubernetes client: %v", err) | |||
| } | |||
|
|
|||
| // Due to scaling issues, the leader election must be configured with a separate k8s client. | |||
| leaderElectKubeClient, err := kubernetes.NewForConfig(kubeConfig) | |||
There was a problem hiding this comment.
Can you please add a user agent to facilitate future debugging as done .e.g here:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-scheduler/app/options/options.go#L326
rramkumar1
force-pushed
the
leader-elect-new-client
branch
from
0757360
to
b49beb8
Compare
|
@wojtek-t -- maybe the leader election code should create the client internally for the default use case? This seems like an easy thing to mess up. |
I'm not the one who created this library and I'm not really maintaining it. But sure - that makes a lot of sense to me. Making kubeconfig a parameter of constructor for leader election makes a lot of sense. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherrypick #623 on 1.4 branch
Due to some scaling issues, we need to configure leader election with a separate k8s client then what is used for other API server operations (watch, events, etc).
This puts ingress-gce in line w/ how scheduler and controller-manager implement leader election.