Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GetNamedPort to Namer #72

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Move GetNamedPort to Namer #72

merged 1 commit into from
Nov 7, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Nov 7, 2017

  • Split off unit tests for namer into namer_test.go

@bowei
Move GetNamedPort to Namer
756d2c1 
- Split off unit tests for namer into namer_test.go
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2017
@bowei bowei requested a review from nicksardo November 7, 2017 00:43
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2017
@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2017
@nicksardo nicksardo merged commit 0d15eed into kubernetes:master Nov 7, 2017
@bowei bowei deleted the named-port branch December 23, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksardo nicksardo Awaiting requested review from nicksardo

Assignees

@nicksardo nicksardo

@nikhiljindal nikhiljindal

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bowei @nicksardo @nikhiljindal @k8s-ci-robot