Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e framework for ILB - Part 2 #852

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Update e2e framework for ILB - Part 2 #852

merged 2 commits into from
Nov 15, 2019

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Sep 13, 2019 •
edited
Loading

Add support for regional resources to gcp.go with minimal changes to the existing fuzzer logic
This allows for whitebox and GC testing of l7-ilb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2019
@MrHohn
Copy link
Member

MrHohn commented Sep 17, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2019
@spencerhance spencerhance force-pushed the fuzzer-updates-2 branch 2 times, most recently from 1f6468e to a656004 Compare September 19, 2019 01:00
bowei
bowei reviewed Oct 7, 2019
View reviewed changes
pkg/fuzz/gcp.go Outdated Show resolved Hide resolved
pkg/fuzz/gcp.go Outdated Show resolved Hide resolved
pkg/fuzz/gcp.go Show resolved Hide resolved
pkg/fuzz/gcp.go Outdated Show resolved Hide resolved
pkg/fuzz/gcp.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2019
@spencerhance
Update fuzzer helpers for l7-Ilb
8700ee6 
Add support for regional resources to gcp.go with minimal changes to the existing fuzzer logic
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2019
@spencerhance spencerhance force-pushed the fuzzer-updates-2 branch 2 times, most recently from 03dfbf9 to b7e88d2 Compare November 9, 2019 03:27
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 13, 2019
@spencerhance
Copy link
Contributor Author

@bowei Can you take another look?

This was referenced Nov 14, 2019
Merged
Merged
@spencerhance
Copy link
Contributor Author

/assign @bowei

bowei
bowei reviewed Nov 15, 2019
View reviewed changes
cmd/e2e-test/basic_test.go
@@ -187,7 +191,7 @@ func TestEdge(t *testing.T) {
t.Logf("GCLB resources createdd (%s/%s)", s.Namespace, tc.ing.Name)

// Perform whitebox testing.
gclb := whiteboxTest(ing, s, t)
gclb := whiteboxTest(ing, s, t, "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix in follow up, for literals like empty string "", add comment in front /*paramName*/"" to aid the reader

@bowei
Copy link
Member

bowei commented Nov 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 83b575f into kubernetes:master Nov 15, 2019
@spencerhance spencerhance deleted the fuzzer-updates-2 branch June 29, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@freehan freehan Awaiting requested review from freehan

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerhance @k8s-ci-robot @MrHohn @bowei