Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Regional Service API in composite types #987

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Use the Regional Service API in composite types #987

merged 2 commits into from
Jan 10, 2020

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Jan 9, 2020

The existing change calls the global API in the GA version, this change adds a check and calls the Regional API if the Regional Key is specified.

@spencerhance

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2020
spencerhance
spencerhance approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prameshj
Copy link
Contributor Author

/assign @MrHohn @bowei

I verified that glbc controller came up and a simple ingress creation worked.

MrHohn
MrHohn approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 691c843 into kubernetes:master Jan 10, 2020
@prameshj prameshj mentioned this pull request Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerhance spencerhance spencerhance approved these changes

@MrHohn MrHohn MrHohn approved these changes

@freehan freehan Awaiting requested review from freehan

Assignees

@bowei bowei

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prameshj @k8s-ci-robot @MrHohn @spencerhance @bowei