Internal LoadBalancer docs needs corrections

[longwuyuan]

• the documentation for deploying internal loadbalancer are outdated. For example default lb on AWS is NLB but docs talk about ELB
• Link to the docs is here
  https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/README.md#additional-internal-load-balancer
• Task is to do installs on at least the 3 popular cloud providers and fix the docs for both description as well as the values of the key:value sets of annotations. It is likely that the value of the annotation needs update
• This task requires AWS, GCP & Azure accounts and may cost some money for compute or LB

/triage accepted
/help-wanted
/good-first-issue

cc @z1cheng

[k8s-ci-robot]

@longwuyuan:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

• the documentation for deploying internal loadbalancer are outdated. For example default lb on AWS is NLB but docs talk about ELB
• Link to the docs is here
  https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/README.md#additional-internal-load-balancer
• Task is to do installs on at least the 3 popular cloud providers and fix the docs for both description as well as the values of the key:value sets of annotations. It is likely that the value of the annotation needs update
• This task requires AWS, GCP & Azure accounts and may cost some money for compute or LB

/triage accepted
/help-wanted
/good-first-issue

cc @z1cheng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[z1cheng]

Thanks @longwuyuan, let me have a try for this one

/assign

[z1cheng]

@longwuyuan I found that only AWS LB needs to be updated:

1. AWS: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.2/guide/service/annotations/#lb-scheme, annotation needs to be service.beta.kubernetes.io/aws-load-balancer-scheme: "internet-facing"
2. Azure: https://learn.microsoft.com/en-us/azure/aks/internal-lb#create-an-internal-load-balancer, annotation: service.beta.kubernetes.io/azure-load-balancer-internal: "true"
3. GCP: https://cloud.google.com/kubernetes-engine/docs/how-to/internal-load-balancing#create:

   For GKE versions 1.17 and later, use the annotation networking.gke.io/load-balancer-type: "Internal". For earlier versions, use the annotation cloud.google.com/load-balancer-type: "Internal"

4. OCI: https://docs.oracle.com/en-us/iaas/Content/ContEng/Tasks/contengcreatingloadbalancer.htm#Creating2, annotation: service.beta.kubernetes.io/oci-load-balancer-internal: "true"

And https://kubernetes.io/docs/concepts/services-networking/service/#internal-load-balancer might be helpful to list the cloud service providers (although it didn't update AWS LB annotation), could we add this link to the doc?

[longwuyuan]

Thank you @z1cheng . I agree with you.

[z1cheng]

Also have a PR to fix the AWS LB annotation: kubernetes/website#41538