Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HELM] Support values references in service annotations #10099

Closed
jkroepke opened this issue Jun 18, 2023 · 6 comments
Closed

[HELM] Support values references in service annotations #10099

jkroepke opened this issue Jun 18, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jkroepke
Copy link
Contributor

jkroepke commented Jun 18, 2023

This is an issue as requested in #10084

I would like to use exists values on service annotations. This this useful where ingress-nginx helm chart is a part of an umbrella helm chart.

Example:

global:
  hostname: grafana.example.com

grafana:
  ingress:
    enabled: true
    annotations:
      cert-manager.io/cluster-issuer: letsencrypt
    ingressClassName: nginx
    hosts:
      - '{{ $.Values.global.hostname }}'

ingress-nginx:
  controller:
    service:
      internal:
        annotations:
          # Example for Azure PLS
          service.beta.kubernetes.io/azure-pls-fqdns: "{{ $.Values.global.hostname }}"
          # Example for Open.Stack
          loadbalancer.openstack.org/hostname: "{{ $.Values.global.hostname }}"
          # Example for Hetzner Cloud
          load-balancer.hetzner.cloud/hostname: "{{ $.Values.global.hostname }}"

The grafana and prometheus helm-chart currently supporting this pattern as well:

No

No

@jkroepke jkroepke added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 18, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkroepke
Copy link
Contributor Author

See #10084 for an implementation proposal.

@github-actions
Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 19, 2023
@jkroepke
Copy link
Contributor Author

Pr to fix is open

@github-actions github-actions bot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 20, 2023
@rikatz
Copy link
Contributor

rikatz commented Oct 11, 2023

As PR is closed, we can close it right?
/close

@k8s-ci-robot
Copy link
Contributor

@rikatz: Closing this issue.

In response to this:

As PR is closed, we can close it right?
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Archived in project
Development

No branches or pull requests

3 participants