Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krew-index not automatically updated on a new release #10197

Closed
VoyTechnology opened this issue Jul 10, 2023 · 4 comments · Fixed by #10321
Closed

krew-index not automatically updated on a new release #10197

VoyTechnology opened this issue Jul 10, 2023 · 4 comments · Fixed by #10321
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@VoyTechnology
Copy link

What happened:

New versions of the plugin are not automatically updated in the krew-index

What you expected to happen:

The pipeline located in .github/workflows/plugin.yaml should create a new PR in the krew-index using the krew-release-bot.

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.): N/A

Kubernetes version (use kubectl version): N/A

Environment: N/A

How to reproduce this issue:

All tagged releases should create a new PR in https://github.com/kubernetes-sigs/krew-index/pulls. Without public output of Github Actions this has to be investigated by the maintainers, therefore I cannot provide any steps to reproduce the issue.

Anything else we need to know:

https://github.com/rajatjindal/krew-release-bot#limitations-of-krew-release-bot mentions that The first version of plugin has to be submitted manually, by plugin author, to the krew-index repo. Perhaps this was not originally done.

The functionality has been originally added in #8812 by @Volatus (mention for FYI purposes)

@VoyTechnology VoyTechnology added the kind/bug Categorizes issue or PR as related to a bug. label Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jul 10, 2023
@longwuyuan
Copy link
Contributor

/help

@k8s-ci-robot
Copy link
Contributor

@longwuyuan:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 13, 2023
@github-actions
Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Aug 13, 2023
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 15, 2023
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 15, 2023
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 16, 2023
k8s-ci-robot pushed a commit that referenced this issue Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants